Port of tgstation/tgstation#90057

Author: Absolucy

code/modules/client/client_defines.dm

@@ -248,9 +248,15 @@
 	var/list/keys_held = list()
 	/// A buffer for combinations such of modifiers + keys (ex: CtrlD, AltE, ShiftT). Format: `"key"` -> `"combo"` (ex: `"D"` -> `"CtrlD"`)
 	var/list/key_combos_held = list()
+
 	/// The direction we WANT to move, based off our keybinds
-	/// Will be udpated to be the actual direction later on
+	/// It updates by client "move_key_(direction)" verbs and tells us exactly when client wants to move and when they don't
 	var/intended_direction = NONE
+	/// The direction we WANT to move, but another one, based off our keybinds too
+	/// It sets by KeyUp and KeyDown verbs but using it alone can lead to key stucks
+	/// It will be combined with intended_direction and used to set the actual direction later on
+	/// We MIGHT be able to do without it, but BYOND does not handle more than 1 +REP command, so alas
+	var/additional_intended_direction = NONE
 	/*
 	** These next two vars are to apply movement for keypresses and releases made while move delayed.
 	** Because discarding that input makes the game less responsive.

code/modules/client/client_procs.dm

@@ -1143,12 +1143,16 @@ GLOBAL_LIST_INIT(blacklisted_builds, list(
 			switch(kb_name)
 				if("North")
 					movement_keys[key] = NORTH
+					winset(src, "default-[REF(key)]", "parent=default;name=[key]+REP;command=move-key-north")
 				if("East")
 					movement_keys[key] = EAST
+					winset(src, "default-[REF(key)]", "parent=default;name=[key]+REP;command=move-key-east")
 				if("West")
 					movement_keys[key] = WEST
+					winset(src, "default-[REF(key)]", "parent=default;name=[key]+REP;command=move-key-west")
 				if("South")
 					movement_keys[key] = SOUTH
+					winset(src, "default-[REF(key)]", "parent=default;name=[key]+REP;command=move-key-south")
 				if(SAY_CHANNEL)
 					var/say = tgui_say_create_open_command(SAY_CHANNEL)
 					winset(src, "default-[REF(key)]", "parent=default;name=[key];command=[say]")

code/modules/keybindings/bindings_atom.dm

@@ -7,14 +7,18 @@
 	// But the move of one mob might poke the client of another, so we do this
 	if(!user)
 		return FALSE
-	var/movement_dir = user.intended_direction | user.next_move_dir_add
-	// If we're not movin anywhere, we aren't movin anywhere
-	// Safe because nothing adds to movement_dir after this moment
-	if(!movement_dir)
+
+	// Handle movement dir queued right after last movement
+	user.intended_direction |= user.next_move_dir_add
+	// We didn't recive any input so it's useless to proceed further
+	if(!user.intended_direction)
 		// No input == our removal would have done nothing
 		// So we can safely forget about it
 		user.next_move_dir_sub = NONE
-		return FALSE
+		return
+
+	var/movement_dir = user.intended_direction | user.additional_intended_direction
+	user.intended_direction = NONE
 
 	if(user.next_move_dir_sub)
 		movement_dir &= ~user.next_move_dir_sub
@@ -41,4 +45,24 @@
 	var/movement_dir = NONE
 	for(var/_key in keys_held)
 		movement_dir |= movement_keys[_key]
-	intended_direction = movement_dir
+	additional_intended_direction = movement_dir
+
+/client/verb/move_key_north()
+	set instant = TRUE
+	set hidden = TRUE
+	intended_direction = NORTH
+
+/client/verb/move_key_south()
+	set instant = TRUE
+	set hidden = TRUE
+	intended_direction = SOUTH
+
+/client/verb/move_key_west()
+	set instant = TRUE
+	set hidden = TRUE
+	intended_direction = WEST
+
+/client/verb/move_key_east()
+	set instant = TRUE
+	set hidden = TRUE
+	intended_direction = EAST

code/modules/keybindings/bindings_client.dm

@@ -48,9 +48,9 @@
 	//the time a key was pressed isn't actually used anywhere (as of 2019-9-10) but this allows easier access usage/checking
 	keys_held[_key] = world.time
 	var/movement = movement_keys[_key]
-	if(movement)
+	if(movement && !movement_locked)
 		calculate_move_dir()
-		if(!movement_locked && !(next_move_dir_sub & movement))
+		if(!(next_move_dir_sub & movement))
 			next_move_dir_add |= movement
 
 	// Client-level keybindings are ones anyone should be able to do at any time
@@ -96,9 +96,9 @@
 	keys_held -= _key
 
 	var/movement = movement_keys[_key]
-	if(movement)
+	if(movement && !movement_locked)
 		calculate_move_dir()
-		if(!movement_locked && !(next_move_dir_add & movement))
+		if(!(next_move_dir_add & movement))
 			next_move_dir_sub |= movement
 
 	// We don't do full key for release, because for mod keys you