Skip to content

Commit 0e1d40d

Browse files
binding: add packageName to the packageInfo class in the binding class
made changes to access packageName from the PackageInfo class. remove getAppBundleId() from Zulip Binding class Add packageName variable to PackageInfo class Fixes zulip#407
1 parent 28b3536 commit 0e1d40d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/model/binding.dart

+3
Original file line numberDiff line numberDiff line change
@@ -303,10 +303,12 @@ class LinuxDeviceInfo implements BaseDeviceInfo {
303303
class PackageInfo {
304304
final String version;
305305
final String buildNumber;
306+
final String packageName;
306307

307308
const PackageInfo({
308309
required this.version,
309310
required this.buildNumber,
311+
required this.packageName,
310312
});
311313
}
312314

@@ -411,6 +413,7 @@ class LiveZulipBinding extends ZulipBinding {
411413
_syncPackageInfo = PackageInfo(
412414
version: info.version,
413415
buildNumber: info.buildNumber,
416+
packageName: info.packageName,
414417
);
415418
} catch (e, st) {
416419
assert(debugLog('Failed to prefetch package info: $e\n$st')); // TODO(log)

test/model/binding.dart

+2-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ class TestZulipBinding extends ZulipBinding {
229229

230230
/// The value that `ZulipBinding.instance.packageInfo` should return.
231231
PackageInfo packageInfoResult = _defaultPackageInfo;
232-
static const _defaultPackageInfo = PackageInfo(version: '0.0.1', buildNumber: '1');
232+
static const _defaultPackageInfo = PackageInfo(version: '0.0.1', buildNumber: '1', packageName: 'com.zulip.flutter.test');
233233

234234
void _resetPackageInfo() {
235235
packageInfoResult = _defaultPackageInfo;
@@ -380,6 +380,7 @@ class TestZulipBinding extends ZulipBinding {
380380
Future<void> toggleWakelock({required bool enable}) async {
381381
_wakelockEnabled = enable;
382382
}
383+
383384
}
384385

385386
class FakeFirebaseMessaging extends Fake implements FirebaseMessaging {

0 commit comments

Comments
 (0)