Skip to content

Commit 542a99b

Browse files
Refactor Automattic#8331 test to prevent false positive
1 parent b0de5f6 commit 542a99b

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

test/model.test.js

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5540,25 +5540,26 @@ describe('Model', function() {
55405540

55415541
return co(function*() {
55425542
const createdUser = yield User.create({ name: 'Hafez' });
5543-
let threw = false;
5543+
5544+
let err;
5545+
55445546
try {
55455547
yield User.bulkWrite([{
55465548
updateOne: {
55475549
filter: { _id: createdUser._id }
55485550
}
55495551
}]);
55505552
}
5551-
catch (err) {
5552-
threw = true;
5553-
assert.equal(err.message, 'Must provide an update object.');
5553+
catch (_err) {
5554+
err = _err;
55545555
}
5555-
finally {
5556-
assert.equal(threw, true);
55575556

5558-
const userAfterUpdate = yield User.findOne({ _id: createdUser._id });
5557+
assert.ok(err);
5558+
assert.equal(err.message, 'Must provide an update object.');
55595559

5560-
assert.equal(userAfterUpdate.name, 'Hafez', 'Document data is not wiped if no update object is provided.');
5561-
}
5560+
const userAfterUpdate = yield User.findOne({ _id: createdUser._id });
5561+
5562+
assert.equal(userAfterUpdate.name, 'Hafez', 'Document data is not wiped if no update object is provided.');
55625563
});
55635564
});
55645565
});

0 commit comments

Comments
 (0)