Skip to content

Inpainting is broken #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Semisol opened this issue Oct 5, 2022 · 22 comments
Closed

Inpainting is broken #1738

Semisol opened this issue Oct 5, 2022 · 22 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@Semisol
Copy link

Semisol commented Oct 5, 2022

Describe the bug
Inpainting is broken

To Reproduce
Steps to reproduce the behavior:

  1. Go to inpaint
  2. Try to inpaint an image with a drawn mask
  3. The output is the same as input

Expected behavior
Inpainting works

Desktop (please complete the following information):

  • OS: macOS, running on Colab
  • Browser: Brave
  • Commit revision: 67d011b
@Semisol Semisol added the bug-report Report of a bug, yet to be confirmed label Oct 5, 2022
@crckdns
Copy link

crckdns commented Oct 5, 2022

can confirm, latent noise is selected, mask is drawn, prompt for inpaint is given, masked area stays as original after resampling.

@Semisol
Copy link
Author

Semisol commented Oct 5, 2022

can confirm, latent noise is selected, mask is drawn, prompt for inpaint is given, masked area stays as original after resampling.

from inspecting myself no mask is being sent to the server, the mask image is all black

@DonStroganotti
Copy link

In my experience that happens when you have a browser addon that interferes with the mask generation, try a different browser or incognito mode/disable addons and report back.

@ProGamerGov
Copy link
Contributor

Do you still have the drawing tool selected? In my experience you need to unselect it before inpainting works.

@Semisol
Copy link
Author

Semisol commented Oct 5, 2022

In my experience that happens when you have a browser addon that interferes with the mask generation, try a different browser or incognito mode/disable addons and report back.

I tried Safari no luck with that.

Do you still have the drawing tool selected? In my experience you need to unselect it before inpainting works.

I don't know how to unselect it.

@crckdns
Copy link

crckdns commented Oct 5, 2022

tried with edge (no plugins/addons, clean) and firefox in incognito mode, same behaviour.
mask is beeing transmitted, as when I select latent noise, the masked area IS being worked on, but reverts in the end to original.

@mayofiddler
Copy link

Inpainting works for me with Firefox but I get the same problem in Img2Img as you describe above. Weirdness.

@a3nima
Copy link

a3nima commented Oct 6, 2022

i did not occur any problem, like the one described.
two problem though I ve got still with the latest version regarding inpainting:

1.inserting a picture in the img2img tab and then trying to send it inpainting (without new results, the original image) leads to an error after which a new tab with SD has to be created in order to be able to add an image to inpainting again.
2. When I send the result of inpainting to the inpainting tab again, the old mask remains hidden but active, so I have to click the undo-button until it's removed.

@Kadah
Copy link

Kadah commented Oct 6, 2022

Inpainting throws this error for me if there is any new lines in the prompt.

AttributeError: 'NoneType' object has no attribute 'groups'

@pcoffey42
Copy link

I get this as well. In my case, it seems to happen when I draw a mask over two different areas. When I only draw one, it works correctly.

@penguincoder
Copy link

I have done some digging on this, as well. It does not work in Firefox, Firefox protected mode, or Edge with some extensions (brighthire and loom) enabled. It does work in Edge with adblock, bitwarden, and raindrop extensions enabled.

The feature does appear to work (at least with 1 mask area), but I haven't found the culprit in Firefox, yet.

@Hime-Hina
Copy link

Hime-Hina commented Oct 16, 2022

I have done some digging on this, as well. It does not work in Firefox, Firefox protected mode, or Edge with some extensions (brighthire and loom) enabled. It does work in Edge with adblock, bitwarden, and raindrop extensions enabled.

The feature does appear to work (at least with 1 mask area), but I haven't found the culprit in Firefox, yet.

I had same issue until DuckDuckGo Privacy Essentials is disabled. Maybe this plugin breaks inpaint

@penguincoder
Copy link

that's definitely the culprit on my machine. great find!

@mayofiddler
Copy link

This is working for me now in Firefox with none of the above fixes.

@BadgerJack
Copy link

Still not working for me with above fixes, in Firefox or in Chrome. Incognito with all plugins disabled for both, output still the same as input. Notably, setting the inpaint to not masked covers the entire area, so it appears the mask is not being interpreted at all.

@FluorescentApe
Copy link

I had this same issue where the inpaint would ignore my mask sometimes. Really frustrating, but @DonStroganotti mentioned an addon could be the culprit. I went through my plugins one by one and it turns out it was "Canvas Fingerprint Defender". If you have the same addon, try turning it off and refreshing your WebUI page. Worked for me!

TLDR; If you have the addon "Canvas Fingerprint Defender", try to disable it and refresh WebUI page.

@myndxero
Copy link

myndxero commented Nov 4, 2022

Feels like it works once in a blue fuckin moon. Then just breaks. Would be awesome if conflicting variables that cause it to crash would offer user-friend messages besides "right is bigger than left." Feel like I move one step forward every 12 hours I fight with in painting to be useful. I had to mask the entire scene and select inpaint not masked just to accomplish a minor addition to the scene. At one point yesterday or day before, don't even remember what day it is anymore, I did a fresh install and setup. Sorry frustrated as all hell. Thanks for your hard work for an awesome free interface.

@MagicAlien
Copy link

I have done some digging on this, as well. It does not work in Firefox, Firefox protected mode, or Edge with some extensions (brighthire and loom) enabled. It does work in Edge with adblock, bitwarden, and raindrop extensions enabled.
The feature does appear to work (at least with 1 mask area), but I haven't found the culprit in Firefox, yet.

I had same issue until DuckDuckGo Privacy Essentials is disabled. Maybe this plugin breaks inpaint

Same experience here: the same problem with DuckDuckGo Privacy Essential enabled; disabling it fix the problem. Also, if the plugin is disabled for the incognito mode, then AUTOMATIC1111 works in incognito mode.

@myndxero
Copy link

myndxero commented Nov 22, 2022

Same experience here: the same problem with DuckDuckGo Privacy Essential enabled; disabling it fix the problem. Also, if the plugin is disabled for the incognito mode, then AUTOMATIC1111 works in incognito mode.

I've completely given up on inpainting in the app and abandoned the notion I'd never need photoshop again. I use both in conjunction now, it's easier to mask in photoshop anyway but maybe a little more tedious if you only need a simple inpaint action.

Thanks for digging in though, maybe it will help extension authors to address the conflict.

@mezotaken
Copy link
Collaborator

mezotaken commented Jan 16, 2023

If i understand correctly, the solution is to temporarily disable DuckDuckGo Privacy Essential. Closing this one, since there's no apparent fix from the repo side. If anyone still experiences this, please let me know.

@WillyamBradberry
Copy link

COMPLETELY BROKEN

@genialgenteel
Copy link

genialgenteel commented May 28, 2023

Necroposting, but I just wanted to say THANK YOU to everyone in this post, especially @FluorescentApe, @DonStroganotti, and @mezotaken. I've been using SD and AUTO1111 for months now, and inpainting has never worked for me...ever. I only recently (in the past few days) discovered a workaround by using a combination of manually drawn Photoshop masks and Inpaint Upload. It never occurred to me that a browser extension was breaking the regular Inpaint. After giving up on inpainting for almost half a year, I've finally gotten it to work in my Firefox browser by disabling CanvasBlocker, a fingerprint-blocking extension, and DuckDuckGo Privacy Essentials like everyone mentioned.

Finally. FINALLY Inpainting works!!! Thanks again! 🙌🏾

(I was brought here by searching DuckDuckGo, ironically, for a solution to this problem, after discovering inpainting did work in Chrome for some reason. I got to this issue first, which then brought me here. Lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests