Skip to content

[Bug]: Style file defaults to ".csv" when "*.csv" is used to load multiple style files. #14681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 6 tasks
MisterSeajay opened this issue Jan 17, 2024 · 1 comment
Open
4 of 6 tasks
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@MisterSeajay
Copy link
Contributor

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

Using the "dev" branch of webui I used the --styles-file command line parameter to specify *.csv as the pattern to use to match styles files. Although all the expected files loaded, when I edited any of them the changes were written to a file named .csv rather than styles.csv.``

Steps to reproduce the problem

  1. Launch webui with the --styles-file command line parameter set to *.csv
  2. Edit & save an existing style
  3. Observe that a new file named .csv has been created

What should have happened?

  1. Launch webui with the --styles-file command line parameter set to *.csv
  2. Edit & save an existing style
  3. The new style should have been saved to styles.csv (i.e. the default name for a style)

More broadly, if a wildcard is used to load styles csv files, then we should default to "styles.csv" if there is no CSV present that matches the simplest possible match of the wildcard. That is, if w*.csv is used to load style files starting with w, and w.csv doesn't itself exist, then use styles.csv as the fall-back default.

What browsers do you use to access the UI ?

Microsoft Edge

Sysinfo

sysinfo-2024-01-17-14-42.json

Console logs

N/A - no error shown in log & bug reporter is already working on a fix

Additional information

No response

@MisterSeajay MisterSeajay added the bug-report Report of a bug, yet to be confirmed label Jan 17, 2024
@MisterSeajay
Copy link
Contributor Author

PR for fix: #14700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

1 participant