Skip to content

Commit 458e921

Browse files
authored
Add parameter ID to gradient check messages (#2748)
1 parent b5cfd88 commit 458e921

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

python/sdist/amici/gradient_check.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,17 @@ def check_finite_difference(
125125
else:
126126
raise NotImplementedError()
127127

128-
_check_close(sensi, fd, atol=atol, rtol=rtol, field=field, ip=ip)
128+
_check_close(
129+
sensi,
130+
fd,
131+
atol=atol,
132+
rtol=rtol,
133+
field=field,
134+
ip=ip,
135+
parameter_id=model.getParameterIds()[ip]
136+
if model.hasParameterIds()
137+
else None,
138+
)
129139

130140
solver.setSensitivityOrder(og_sensitivity_order)
131141
model.setParameters(og_parameters)
@@ -256,6 +266,7 @@ def _check_close(
256266
rtol: float,
257267
field: str,
258268
ip: int | None = None,
269+
parameter_id: str | None = None,
259270
verbose: bool | None = True,
260271
) -> None:
261272
"""
@@ -280,6 +291,9 @@ def _check_close(
280291
:param ip:
281292
parameter index, for more informative output
282293
294+
:param parameter_id:
295+
parameter ID, for more informative output
296+
283297
:param verbose:
284298
produce a more verbose error message in case of unmatched expectations
285299
"""
@@ -292,6 +306,8 @@ def _check_close(
292306
check_type = "Regression check"
293307
else:
294308
index_str = f"at index ip={ip} "
309+
if parameter_id:
310+
index_str += f"({parameter_id}) "
295311
check_type = "FD check"
296312

297313
lines = [

0 commit comments

Comments
 (0)