Fix Model::addAdjointQuadratureEventUpdate (#2787)

dweindl · web-flow · commit 2993f0904c2d · 2025-06-16T17:21:46.000+02:00
It seems like `xQB` should be passed by reference to `Model::addAdjointQuadratureEventUpdate`. So far, this was passed by value, and all updates by that function were lost. Related to #18.
diff --git a/include/amici/model.h b/include/amici/model.h
@@ -1332,7 +1332,7 @@ class Model : public AbstractModel, public ModelDimensions {
      * @param xdot_old Value of residual function before event
      */
     void addAdjointQuadratureEventUpdate(
-        AmiVector xQB, int const ie, realtype const t, AmiVector const& x,
+        AmiVector& xQB, int const ie, realtype const t, AmiVector const& x,
         AmiVector const& xB, AmiVector const& xdot, AmiVector const& xdot_old
     );
 
diff --git a/src/model.cpp b/src/model.cpp
@@ -1525,7 +1525,7 @@ void Model::addAdjointStateEventUpdate(
 }
 
 void Model::addAdjointQuadratureEventUpdate(
-    AmiVector xQB, int const ie, realtype const t, AmiVector const& x,
+    AmiVector &xQB, int const ie, realtype const t, AmiVector const& x,
     AmiVector const& xB, AmiVector const& xdot, AmiVector const& xdot_old
 ) {
     for (int ip = 0; ip < nplist(); ip++) {

Original file line number	Diff line number	Diff line change
`@@ -1525,7 +1525,7 @@ void Model::addAdjointStateEventUpdate(`
`1525`	`1525`	`}`
`1526`	`1526`
`1527`	`1527`	`void Model::addAdjointQuadratureEventUpdate(`
`1528`		`- AmiVector xQB, int const ie, realtype const t, AmiVector const& x,`
	`1528`	`+ AmiVector &xQB, int const ie, realtype const t, AmiVector const& x,`
`1529`	`1529`	`AmiVector const& xB, AmiVector const& xdot, AmiVector const& xdot_old`
`1530`	`1530`	`) {`
`1531`	`1531`	`for (int ip = 0; ip < nplist(); ip++) {`