Skip to content

Commit 9fd123c

Browse files
- some warning fixes
1 parent 9c7d2b5 commit 9fd123c

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

Sources/ImmutableMappable.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ public extension Mapper where N: ImmutableMappable {
214214
// MARK: Array mapping functions
215215

216216
public func mapArray(JSONArray: [[String: Any]]) throws -> [N] {
217-
return try JSONArray.flatMap(mapOrFail)
217+
return try JSONArray.compactMap(mapOrFail)
218218
}
219219

220220
public func mapArray(JSONString: String) throws -> [N] {

Sources/Map.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public final class Map {
131131
}
132132
} else if value == nil && T.self == [Float].self {
133133
if let v = currentValue as? [Double] {
134-
return v.flatMap{ Float($0) } as? T
134+
return v.compactMap{ Float($0) } as? T
135135
}
136136
} else if value == nil && T.self == [String:Float].self {
137137
if let v = currentValue as? [String:Double] {

Sources/Mapper.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ extension Mapper where N: Hashable {
427427
/// Maps an Set of JSON dictionary to an array of Mappable objects
428428
public func mapSet(JSONArray: [[String: Any]]) -> Set<N> {
429429
// map every element in JSON array to type N
430-
return Set(JSONArray.flatMap(map))
430+
return Set(JSONArray.compactMap(map))
431431
}
432432

433433
///Maps a Set of Objects to a Set of JSON dictionaries [[String : Any]]

Sources/TransformOperators.swift

+5-5
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ public func <- <Transform: TransformType>(left: inout [[Transform.Object]], righ
458458
left >>> right
459459
case .fromJSON where map.isKeyPresent:
460460
guard let original2DArray = map.currentValue as? [[Any]] else { break }
461-
let transformed2DArray = original2DArray.flatMap { values in
461+
let transformed2DArray = original2DArray.compactMap { values in
462462
fromJSONArrayWithTransform(values as Any?, transform: transform)
463463
}
464464
FromJSON.basicType(&left, object: transformed2DArray)
@@ -470,7 +470,7 @@ public func <- <Transform: TransformType>(left: inout [[Transform.Object]], righ
470470
public func >>> <Transform: TransformType>(left: [[Transform.Object]], right: (Map, Transform)) {
471471
let (map, transform) = right
472472
if map.mappingType == .toJSON{
473-
let transformed2DArray = left.flatMap { values in
473+
let transformed2DArray = left.compactMap { values in
474474
toJSONArrayWithTransform(values, transform: transform)
475475
}
476476
ToJSON.basicType(transformed2DArray, map: map)
@@ -485,7 +485,7 @@ public func <- <Transform: TransformType>(left: inout [[Transform.Object]]?, rig
485485
left >>> right
486486
case .fromJSON where map.isKeyPresent:
487487
guard let original2DArray = map.currentValue as? [[Any]] else { break }
488-
let transformed2DArray = original2DArray.flatMap { values in
488+
let transformed2DArray = original2DArray.compactMap { values in
489489
fromJSONArrayWithTransform(values as Any?, transform: transform)
490490
}
491491
FromJSON.optionalBasicType(&left, object: transformed2DArray)
@@ -497,7 +497,7 @@ public func <- <Transform: TransformType>(left: inout [[Transform.Object]]?, rig
497497
public func >>> <Transform: TransformType>(left: [[Transform.Object]]?, right: (Map, Transform)) {
498498
let (map, transform) = right
499499
if map.mappingType == .toJSON {
500-
let transformed2DArray = left?.flatMap { values in
500+
let transformed2DArray = left?.compactMap { values in
501501
toJSONArrayWithTransform(values, transform: transform)
502502
}
503503
ToJSON.optionalBasicType(transformed2DArray, map: map)
@@ -513,7 +513,7 @@ public func <- <Transform: TransformType>(left: inout [[Transform.Object]]!, rig
513513
left >>> right
514514
case .fromJSON where map.isKeyPresent:
515515
guard let original2DArray = map.currentValue as? [[Any]] else { break }
516-
let transformed2DArray = original2DArray.flatMap { values in
516+
let transformed2DArray = original2DArray.compactMap { values in
517517
fromJSONArrayWithTransform(values as Any?, transform: transform)
518518
}
519519
FromJSON.optionalBasicType(&left, object: transformed2DArray)

Tests/ObjectMapperTests/BasicTypesTestsToJSON.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ class BasicTypesTestsToJSON: XCTestCase {
5454

5555
//TODO This test could be improved
5656
XCTAssertNotNil(JSONWithNil)
57-
XCTAssertTrue((JSONWithNil!.characters.count) > 5)
58-
XCTAssertTrue((JSONWithNil!.characters.count) != (JSONWithoutNil!.characters.count))
57+
XCTAssertTrue((JSONWithNil!.count) > 5)
58+
XCTAssertTrue((JSONWithNil!.count) != (JSONWithoutNil!.count))
5959
}
6060

6161
func testMappingBoolToJSON(){

0 commit comments

Comments
 (0)