Skip to content

Commit 8242721

Browse files
committed
Merge release/v1.4.0 into master
2 parents 57f4fd1 + cc97f18 commit 8242721

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

ThunderTable.xcodeproj/project.pbxproj

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,7 @@
591591
INFOPLIST_FILE = ThunderTableDemo/Info.plist;
592592
IPHONEOS_DEPLOYMENT_TARGET = 11.2;
593593
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
594+
MARKETING_VERSION = 1.4.0;
594595
PRODUCT_BUNDLE_IDENTIFIER = com.3sidedcube.ThunderTableDemo;
595596
PRODUCT_NAME = "$(TARGET_NAME)";
596597
SWIFT_VERSION = 5.0;
@@ -613,6 +614,7 @@
613614
INFOPLIST_FILE = ThunderTableDemo/Info.plist;
614615
IPHONEOS_DEPLOYMENT_TARGET = 11.2;
615616
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
617+
MARKETING_VERSION = 1.4.0;
616618
PRODUCT_BUNDLE_IDENTIFIER = com.3sidedcube.ThunderTableDemo;
617619
PRODUCT_NAME = "$(TARGET_NAME)";
618620
SWIFT_VERSION = 5.0;
@@ -752,7 +754,7 @@
752754
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
753755
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
754756
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
755-
MARKETING_VERSION = 1.3.7;
757+
MARKETING_VERSION = 1.4.0;
756758
PRODUCT_BUNDLE_IDENTIFIER = com.threesidedcube.ThunderTable;
757759
PRODUCT_NAME = "$(TARGET_NAME)";
758760
SKIP_INSTALL = YES;
@@ -777,7 +779,7 @@
777779
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
778780
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
779781
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
780-
MARKETING_VERSION = 1.3.7;
782+
MARKETING_VERSION = 1.4.0;
781783
PRODUCT_BUNDLE_IDENTIFIER = com.threesidedcube.ThunderTable;
782784
PRODUCT_NAME = "$(TARGET_NAME)";
783785
SKIP_INSTALL = YES;

ThunderTable/ImageView.swift

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,9 @@ public extension UIImageView {
130130
/// - parameter withPlaceholder: The image to use as a placeholder for the loading image (Optional)
131131
/// - parameter imageSize: The size of the final image which will be loaded from the URL
132132
/// - parameter animated: Whether the loading image should animate in when retrieved
133+
/// - parameter callCompletionForIntermediaryLoads: Whether `completion` should be called for intermediary image loads
133134
/// - parameter completion: A closure which will be called upon the completed load of the image.
134-
func set(imageURLS: [URL]?, withPlaceholder: UIImage?, imageSize: CGSize = CGSize.zero, animated: Bool = false, completion: ImageViewSetImageURLCompletion?) {
135+
func set(imageURLS: [URL]?, withPlaceholder: UIImage?, imageSize: CGSize = CGSize.zero, animated: Bool = false, callCompletionForIntermediaryLoads: Bool = false, completion: ImageViewSetImageURLCompletion?) {
135136

136137
finalSize = imageSize
137138
cancelCurrentRequestOperations()
@@ -200,6 +201,10 @@ public extension UIImageView {
200201
welf.imageURLS = nil
201202
welf.completion?(image, error)
202203
welf.completion = nil
204+
205+
} else if callCompletionForIntermediaryLoads {
206+
207+
welf.completion?(image, error)
203208
}
204209
})
205210
})

ThunderTableDemo/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<key>CFBundlePackageType</key>
1616
<string>APPL</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>1.0</string>
18+
<string>$(MARKETING_VERSION)</string>
1919
<key>CFBundleVersion</key>
2020
<string>1</string>
2121
<key>LSRequiresIPhoneOS</key>

0 commit comments

Comments
 (0)