Skip to content

Commit 85a6e59

Browse files
committed
Update position of s
tatus/validity check when creating comment
1 parent ad131d5 commit 85a6e59

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

script/reviewer.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,14 @@ func (r *Reviewer) createComment(status Status) {
6060
body = "This application is closed and changes will not be reviewed. If this is an error, contact us at [[email protected]](mailto:[email protected])."
6161
} else if status == Approved {
6262
body = fmt.Sprintf("This application has already been approved and changes will not be reviewed. If you would like to modify the details of your application, submit a pull request against the stored [application data](%s). If this is an error, contact us at [[email protected]](mailto:[email protected]).", dataPath)
63-
} else if status == Reviewing && r.application.IsValid() {
64-
title = "### 👍 Application still valid"
65-
body = fmt.Sprintf("\n\n%s\n\nWe’ve evaluated your updated application and it is still valid.", details)
6663
} else if r.application.IsValid() {
67-
title = "### ✅ Your application is valid"
68-
body = fmt.Sprintf("\n\n%s\n\nThanks for applying! Next step: our team will review your application and may have follow-up questions. You can still make changes to your application and it’ll be re-evaluated.", details)
64+
if status == Reviewing {
65+
title = "### 👍 Application still valid"
66+
body = fmt.Sprintf("\n\n%s\n\nWe’ve evaluated your updated application and it is still valid.", details)
67+
} else {
68+
title = "### ✅ Your application is valid"
69+
body = fmt.Sprintf("\n\n%s\n\nThanks for applying! Next step: our team will review your application and may have follow-up questions. You can still make changes to your application and it’ll be re-evaluated.", details)
70+
}
6971
} else {
7072
title = "### ❌ Your application is invalid"
7173
body = fmt.Sprintf("\n\n%s\n\nThe following issues need to be addressed:\n\n%s", details, r.application.RenderProblems())

0 commit comments

Comments
 (0)