BREAKING CHANGE: Use ij-platform 242 with java 21 (#156)

fix missing kotlin.jvmToolchain upgrade

Author: 134130

.github/workflows/build.yml

@@ -56,7 +56,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 17
+          java-version: 21
 
       # Setup Gradle
       - name: Setup Gradle
@@ -125,7 +125,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 17
+          java-version: 21
 
       # Setup Gradle
       - name: Setup Gradle
@@ -178,7 +178,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 17
+          java-version: 21
 
       # Run Qodana inspections
       - name: Qodana - Code Inspection
@@ -208,7 +208,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 17
+          java-version: 21
 
       # Setup Gradle
       - name: Setup Gradle
@@ -249,7 +249,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 17
+          java-version: 21
 
       # Setup Gradle
       - name: Setup Gradle

.github/workflows/release.yml

@@ -35,7 +35,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 17
+          java-version: 21
 
       # Setup Gradle
       - name: Setup Gradle

.github/workflows/run-ui-tests.yml

@@ -40,7 +40,7 @@ jobs:
         uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 17
+          java-version: 21
 
       # Setup Gradle
       - name: Setup Gradle

build.gradle.kts

@@ -24,15 +24,15 @@ version = providers.gradleProperty("pluginVersion").get()
 
 // Set the JVM language level used to build the project.
 kotlin {
-    jvmToolchain(17)
+    jvmToolchain(21)
 }
 
 // Dependencies are managed with Gradle version catalog - read more: https://docs.gradle.org/current/userguide/platforms.html#sub:version-catalog
 dependencies {
     testImplementation(libs.junit)
 
     intellijPlatform {
-        create(IntelliJPlatformType.IntellijIdeaCommunity, "2022.3.3", false)
+        create(IntelliJPlatformType.IntellijIdeaCommunity, providers.gradleProperty("platformVersion"), false)
 
         pluginModule(implementation(project(":mise-products-goland")))
         pluginModule(implementation(project(":mise-products-gradle")))
@@ -106,7 +106,7 @@ intellijPlatform {
 
     pluginVerification {
         ides {
-//            recommended()
+            recommended()
         }
     }
 
@@ -166,7 +166,7 @@ allprojects {
 
     tasks.withType<Detekt>().configureEach {
         enabled = false
-        jvmTarget = "17"
+        jvmTarget = "21"
         reports {
             xml.required = true
             html.required = true
@@ -179,7 +179,7 @@ allprojects {
         input.from(tasks.withType<Detekt>().map { it.reports.sarif.outputLocation })
     }
     tasks.withType<DetektCreateBaselineTask>().configureEach {
-        jvmTarget = "17"
+        jvmTarget = "21"
     }
 }
 

gradle.properties

@@ -7,8 +7,8 @@ pluginRepositoryUrl = https://github.com/134130/intellij-mise
 pluginVersion=3.5.0
 
 # Supported build number ranges and IntelliJ Platform versions -> https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
-pluginSinceBuild=233
-platformVersion=2023.3.6
+pluginSinceBuild=242
+platformVersion=2024.2
 
 # Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html
 # Example: platformPlugins = com.intellij.java, com.jetbrains.php:203.4449.22

mise.toml

@@ -1,2 +1,2 @@
 [tools]
-java = '17'
+java = '21'

modules/core/src/main/kotlin/com/github/l34130/mise/core/MiseErrorReportSubmitter.kt

@@ -3,6 +3,7 @@ package com.github.l34130.mise.core
 import com.github.l34130.mise.core.command.MiseCommandLine
 import com.github.l34130.mise.core.notification.MiseNotificationService
 import com.intellij.diagnostic.AbstractMessage
+import com.intellij.diagnostic.LogMessage
 import com.intellij.diagnostic.PluginException
 import com.intellij.ide.DataManager
 import com.intellij.openapi.actionSystem.CommonDataKeys
@@ -45,7 +46,7 @@ class MiseErrorReportSubmitter : ErrorReportSubmitter() {
                     val description = additionalInfo ?: ""
                     var attachments = listOf<Attachment>()
 
-                    if (event.data is AbstractMessage) {
+                    if (event.data is LogMessage) {
                         throwable = (event.data as AbstractMessage).throwable
                         attachments = (event.data as AbstractMessage).includedAttachments
                     }

modules/core/src/main/kotlin/com/github/l34130/mise/core/util/TerminalUtils.kt

@@ -1,8 +1,10 @@
 package com.github.l34130.mise.core.util
 
+import com.github.l34130.mise.core.baseDirectory
 import com.intellij.openapi.components.service
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.wm.ToolWindowManager
+import org.jetbrains.plugins.terminal.ShellTerminalWidget
 import org.jetbrains.plugins.terminal.TerminalToolWindowFactory
 import org.jetbrains.plugins.terminal.TerminalToolWindowManager
 
@@ -12,8 +14,8 @@ object TerminalUtils {
         command: String,
         tabName: String? = null,
     ) {
-        val widget =
-            project.service<TerminalToolWindowManager>().createLocalShellWidget(project.basePath, tabName ?: "Mise")
+        val shellWidget = project.service<TerminalToolWindowManager>().createShellWidget(project.baseDirectory(), tabName ?: "Mise", true, true)
+        val widget = ShellTerminalWidget.toShellJediTermWidgetOrThrow(shellWidget)
 
         project
             .service<ToolWindowManager>()

qodana.yml

@@ -3,7 +3,7 @@
 
 version: 1.0
 linter: jetbrains/qodana-jvm-community:latest
-projectJDK: "17"
+projectJDK: "21"
 profile:
   name: qodana.recommended
 exclude: