bb/fix specs (#1475)

* chore(playwright): fix testID for token balance items and enhance send page navigation logic

* fix(types): remove duplicate user field in Fingerprint interface in snaplet-client.d.ts

* fix(types): remove duplicate user field in Fingerprint interface in snaplet-client.d.ts

Author: 0xBigBoss

packages/app/features/home/InvestmentBalanceList.tsx

@@ -26,6 +26,7 @@ export const InvestmentsBalanceList = () => {
   return investmentCoins.map((coin) => (
     <Fragment key={`token-balance-list-${coin.label}`}>
       <TokenBalanceItem
+        testID={`token-balance-list-${coin.label}`}
         coin={coin}
         jc={'space-between'}
         ai={'center'}
@@ -144,7 +145,14 @@ export const AddInvestmentLink = () => {
   const hoverStyles = useHoverStyles()
 
   return (
-    <LinkableButton circular href="/trade" p="$2" size="$5" hoverStyle={hoverStyles}>
+    <LinkableButton
+      circular
+      href="/trade"
+      p="$2"
+      size="$5"
+      hoverStyle={hoverStyles}
+      title="Add Investment"
+    >
       <LinkableButton.Icon>
         <IconPlus size="$5" color="$color10" />
       </LinkableButton.Icon>

packages/app/utils/useSearchResultHref.tsx

@@ -15,8 +15,14 @@ export const useSearchResultHref = (profile?: SearchResultCommonType) => {
         return ''
       case path === '/activity':
         return `${baseMainnet.blockExplorers.default.url}/address/${query}`
-      case path === '/send' || path === '/':
-        return `/send?recipient=${query}&idType=address`
+      case path === '/send' || path === '/': {
+        const _sendParams = JSON.parse(JSON.stringify(sendParams)) //JSON makes sure we don't pass undefined values
+        return `/send?${new URLSearchParams({
+          ..._sendParams,
+          recipient: query,
+          idType: 'address',
+        }).toString()}`
+      }
 
       default:
         throw new Error(`Unhandled path: ${path}`)

packages/playwright/tests/fixtures/earn/EarnDepositPage.ts

@@ -23,7 +23,8 @@ export class EarnDepositPage {
 
   async navigate(coin: { symbol: string }) {
     await this.page.goto('/')
-    await this.page.getByRole('link', { name: 'Earn' }).click()
+    // The Earn link is now inside the SavingsBalanceCard
+    await this.page.getByText('Savings').click()
     await this.page.waitForURL('/earn')
     await expect(this.startEarningButton).toBeVisible()
     await this.startEarningButton.click()
@@ -63,8 +64,12 @@ export class EarnDepositPage {
   }
 
   async submit() {
-    await expect(this.page.getByRole('button', { name: 'Confirm Deposit' })).toBeVisible()
-    await expect(this.page.getByRole('button', { name: 'Confirm Deposit' })).toBeEnabled()
+    await expect(async () => {
+      await expect(this.page.getByRole('button', { name: 'Confirm Deposit' })).toBeVisible()
+      await expect(this.page.getByRole('button', { name: 'Confirm Deposit' })).toBeEnabled()
+    }).toPass({
+      timeout: 15000,
+    })
     await this.page.getByRole('button', { name: 'Confirm Deposit' }).click()
     await expect(this.page.getByText('Deposit Submitted', { exact: true })).toBeVisible({
       timeout: 10000,

packages/playwright/tests/fixtures/swap/index.ts

@@ -77,10 +77,15 @@ export class SwapFormPage {
   }
 
   async goto() {
-    log('goto /trade')
+    log('goto /?token=investments')
     await this.page.goto('/')
-    await this.page.getByRole('link', { name: 'Trade' }).nth(0).click()
-    await this.page.waitForURL('/trade')
+    const investButton = this.page.getByText('Invest', { exact: true })
+    await expect(investButton).toBeVisible()
+    await investButton.click()
+    await this.page.waitForURL('/?token=investments')
+    const addInvestmentButton = this.page.getByRole('link', { name: 'Add Investment' })
+    await expect(addInvestmentButton).toBeVisible()
+    await addInvestmentButton.click()
     await this.validatePageVisible()
   }
 

packages/playwright/tests/send.onboarded.spec.ts

@@ -4,7 +4,7 @@ import { userOnboarded } from '@my/snaplet/models'
 import type { Database } from '@my/supabase/database.types'
 import { mergeTests, type Page } from '@playwright/test'
 import type { SupabaseClient } from '@supabase/supabase-js'
-import { coins, type coin, ethCoin } from 'app/data/coins'
+import { coins, type coin, ethCoin, stableCoins } from 'app/data/coins'
 import { assert } from 'app/utils/assert'
 import { hexToBytea } from 'app/utils/hexToBytea'
 import { shorten } from 'app/utils/strings'
@@ -101,9 +101,25 @@ for (const token of [...coins, ethCoin]) {
       // goto send page
       await page.goto('/')
 
-      //Press send button
-      await page.locator(`a[href="/?token=${token.token}"]`).click()
-      await page.getByTestId('send-quick-action').click()
+      //Press send button - navigate to correct category based on token type
+      const isStableCoin = stableCoins.some((coin) => coin.symbol === token.symbol)
+
+      if (isStableCoin) {
+        const cashBalButton = page.getByText('Cash Balance')
+        await expect(cashBalButton).toBeVisible()
+        await cashBalButton.click()
+      } else {
+        const investmentsButton = page.getByText('Invest', { exact: true })
+        await expect(investmentsButton).toBeVisible()
+        await investmentsButton.click()
+      }
+
+      const tokenButton = page.getByTestId(`token-balance-list-${token.label}`)
+      await expect(tokenButton).toBeVisible()
+      await tokenButton.click()
+      const sendButton = page.getByTestId('send-quick-action')
+      await expect(sendButton).toBeVisible()
+      await sendButton.click()
 
       // fill search input
       const searchInput = page.getByRole('search', { name: 'query' })
@@ -134,6 +150,7 @@ for (const token of [...coins, ethCoin]) {
         expect(Object.fromEntries(url.searchParams.entries())).toMatchObject({
           recipient: query,
           idType,
+          sendToken: token.token,
         })
       }).toPass({
         timeout: 5000,

packages/playwright/tests/swap.onboarded.spec.ts

@@ -171,7 +171,7 @@ test("can't access form page without accepting risk dialog", async ({ page, swap
   await expect(async () => {
     const currentUrl = new URL(page.url())
     expect(currentUrl.pathname).toBe('/')
-    expect(currentUrl.searchParams.toString()).toBe('')
+    expect(currentUrl.searchParams.toString()).toBe('token=investments')
   }).toPass({ timeout: 5000 })
 })
 

packages/snaplet/.snaplet/snaplet-client.d.ts

@@ -1086,4 +1086,4 @@ export interface Fingerprint {
     deletedAt?: FingerprintDateField;
     user?: FingerprintRelationField;
     sendAccountCredentialsByCredentialId?: FingerprintRelationField;
-  }}
+  }}