Removed transfer direction indicator (#1415)

Author: musidlo

packages/app/features/activity/ActivityAvatar.tsx

@@ -1,5 +1,5 @@
 import { Avatar, LinkableAvatar, type LinkableAvatarProps, Spinner, XStack } from '@my/ui'
-import { ArrowDown, ArrowUp, Minus, Plus } from '@tamagui/lucide-icons'
+import { Minus, Plus } from '@tamagui/lucide-icons'
 import { AvatarSendEarnDeposit } from 'app/components/avatars'
 import { AvatarSendEarnWithdraw } from 'app/components/avatars/AvatarSendEarnWithdraw'
 import { IconUpgrade } from 'app/components/icons'
@@ -57,9 +57,7 @@ export function ActivityAvatar({
         onPress={(e) => {
           e.stopPropagation()
         }}
-        position={'relative'}
       >
-        <TransferDirectionIndicator activity={activity} />
         <LinkableAvatar size="$4.5" br="$4" gap="$2" href={`/profile/${user.send_id}`} {...props}>
           {(() => {
             switch (true) {
@@ -189,25 +187,3 @@ const TradeActivityAvatar = ({ activity }: { activity: Activity }) => {
     </XStack>
   )
 }
-
-const TransferDirectionIndicator = ({ activity }: { activity: Activity }) => {
-  const { to_user } = activity
-
-  return (
-    <XStack
-      position={'absolute'}
-      top={0}
-      right={0}
-      transform={'translate(30%, -30%)'}
-      bc={'$olive'}
-      borderRadius={999}
-      shadowColor={'#000000'}
-      shadowOffset={{ width: 0, height: 2 }}
-      shadowOpacity={0.7}
-      shadowRadius={8}
-      zIndex={1}
-    >
-      {to_user?.id ? <ArrowDown size={'$1'} /> : <ArrowUp size={'$1'} />}
-    </XStack>
-  )
-}

packages/app/utils/activity.tsx

@@ -333,8 +333,6 @@ export function eventNameFromActivity({
       return 'Send Earn Deposit'
     case isSendEarnWithdrawEvent(activity):
       return 'Send Earn Withdraw'
-    case isTemporalTransfer:
-      return note || ''
     case isERC20Transfer && isAddressEqual(data.f, sendtagCheckoutAddress[baseMainnet.id]):
       return 'Revenue Share'
     case isSendTokenUpgradeEvent(activity):
@@ -349,10 +347,10 @@ export function eventNameFromActivity({
         return 'Trade'
       }
       return 'Deposit'
-    case isTransferOrReceive && !!to_user?.id:
-      return note || ''
-    case isTransferOrReceive && !!from_user?.id:
-      return note || ''
+    case (isTransferOrReceive || isTemporalTransfer) && !!to_user?.id:
+      return note || 'Received'
+    case (isTransferOrReceive || isTemporalTransfer) && !!from_user?.id:
+      return note || 'Sent'
     case isTagReceiptsEvent(activity) || isTagReceiptUSDCEvent(activity):
       return 'Sendtag Registered'
     case isReferralsEvent(activity) && !!from_user?.id: