Weighted average investment percent change

Author: youngkidwarrior

packages/app/features/home/InvestmentsBalanceCard.tsx

@@ -13,6 +13,7 @@ import { useMultipleTokensMarketData } from 'app/utils/coin-gecko'
 import { useMemo } from 'react'
 import { IconError } from 'app/components/icons'
 import { useCoins } from 'app/provider/coins'
+import { formatUnits } from 'viem'
 
 export const InvestmentsBalanceCard = () => {
   const [queryParams, setParams] = useRootScreenParams()
@@ -96,22 +97,41 @@ export const InvestmentsBalanceCard = () => {
 }
 
 function InvestmentsAggregate() {
-  const tokenIds = useCoins()
-    .investmentCoins.filter((c) => c?.balance && c.balance > 0n)
-    .map((c) => c.coingeckoTokenId)
+  const coins = useCoins().investmentCoins.filter((c) => c?.balance && c.balance > 0n)
 
+  const tokenIds = coins.map((c) => c.coingeckoTokenId)
   const { data: marketData, isLoading, isError } = useMultipleTokensMarketData(tokenIds)
+
+  const { totalValue, assetValues } = useMemo(() => {
+    if (!marketData?.length) return { totalValue: 0, assetValues: [] }
+
+    // Calculate values for each asset and total
+    const assetValues = coins.map((coin) => {
+      const marketInfo = marketData.find((m) => m.id === coin.coingeckoTokenId)
+      if (!marketInfo || !coin.balance) return { value: 0, percentChange: 0 }
+
+      const parsedBalance = formatUnits(coin.balance, coin.decimals)
+      return {
+        value: Number(parsedBalance) * (marketInfo.current_price ?? 0),
+        percentChange: marketInfo.price_change_percentage_24h ?? 0,
+      }
+    })
+
+    const totalValue = assetValues.reduce((sum, asset) => sum + asset.value, 0)
+
+    return { totalValue, assetValues }
+  }, [marketData, coins])
+
   const aggregatePercentage = useMemo(() => {
-    if (!marketData?.length) return 0
+    if (totalValue <= 0) return 0
 
-    // Simple average of percentage changes
-    const aggregatePercentage =
-      marketData.reduce((total, coin) => {
-        return total + (coin?.price_change_percentage_24h ?? 0)
-      }, 0) / marketData.length
+    const weightedPercentage = assetValues.reduce((sum, asset) => {
+      const weight = asset.value / totalValue
+      return sum + asset.percentChange * weight
+    }, 0)
 
-    return Number(aggregatePercentage.toFixed(2))
-  }, [marketData])
+    return Math.round(weightedPercentage * 100) / 100
+  }, [totalValue, assetValues])
 
   if (tokenIds.length === 0)
     return (