Fix comments #2

Author: Kolezhniuk

src/iden3comm/constants.ts

@@ -73,5 +73,5 @@ export const SUPPORTED_PUBLIC_KEY_TYPES = {
   ]
 };
 
-export const DEFAULT_PROOF_VERIFY_OPT = 1 * 60 * 60 * 1000; // 1 hour
-export const DEFAULT_AUTH_VERIFY_OPTS = 5 * 60 * 1000; // 5 minutes
+export const DEFAULT_PROOF_VERIFY_DELAY = 1 * 60 * 60 * 1000; // 1 hour
+export const DEFAULT_AUTH_VERIFY_DELAY = 5 * 60 * 1000; // 5 minutes

src/iden3comm/packers/zkp.ts

@@ -22,7 +22,7 @@ import {
 } from '../errors';
 import { MediaType } from '../constants';
 import { byteDecoder, byteEncoder } from '../../utils';
-import { DEFAULT_AUTH_VERIFY_OPTS } from '../constants';
+import { DEFAULT_AUTH_VERIFY_DELAY } from '../constants';
 
 const { getProvingMethod } = proving;
 
@@ -94,7 +94,7 @@ export class ZKPPacker implements IPacker {
     public readonly provingParamsMap: Map<string, ProvingParams>,
     public readonly verificationParamsMap: Map<string, VerificationParams>,
     private readonly _opts: StateVerificationOpts = {
-      acceptedStateTransitionDelay: DEFAULT_AUTH_VERIFY_OPTS
+      acceptedStateTransitionDelay: DEFAULT_AUTH_VERIFY_DELAY
     }
   ) {}
 

src/proof/proof-service.ts

@@ -491,7 +491,7 @@ export class ProofService implements IProofService {
     circuitId: string,
     pubSignals: string[],
     opts: StateVerificationOpts = {
-      acceptedStateTransitionDelay: PROTOCOL_CONSTANTS.DEFAULT_AUTH_VERIFY_OPTS
+      acceptedStateTransitionDelay: PROTOCOL_CONSTANTS.DEFAULT_AUTH_VERIFY_DELAY
     }
   ): Promise<boolean> {
     if (circuitId !== CircuitId.AuthV2) {
@@ -524,12 +524,10 @@ export class ProofService implements IProofService {
 
       if (
         timeDiff >
-        (opts?.acceptedStateTransitionDelay ?? PROTOCOL_CONSTANTS.DEFAULT_AUTH_VERIFY_OPTS)
+        (opts?.acceptedStateTransitionDelay ?? PROTOCOL_CONSTANTS.DEFAULT_AUTH_VERIFY_DELAY)
       ) {
         throw new Error('global state is outdated');
       }
-
-      return true;
     }
 
     return true;

src/proof/verifiers/pub-signals-verifier.ts

@@ -393,7 +393,7 @@ export class PubSignalsVerifier {
     // verify state
     const gist = await this.checkGlobalState(authV2PubSignals.GISTRoot, this.userId);
 
-    let acceptedStateTransitionDelay = PROTOCOL_CONSTANTS.DEFAULT_AUTH_VERIFY_OPTS;
+    let acceptedStateTransitionDelay = PROTOCOL_CONSTANTS.DEFAULT_AUTH_VERIFY_DELAY;
     if (opts?.acceptedStateTransitionDelay) {
       acceptedStateTransitionDelay = opts.acceptedStateTransitionDelay;
     }
@@ -712,7 +712,7 @@ export class PubSignalsVerifier {
     );
 
     const acceptedStateTransitionDelay =
-      opts?.acceptedStateTransitionDelay ?? PROTOCOL_CONSTANTS.DEFAULT_PROOF_VERIFY_OPT;
+      opts?.acceptedStateTransitionDelay ?? PROTOCOL_CONSTANTS.DEFAULT_PROOF_VERIFY_DELAY;
 
     if (!issuerNonRevStateResolved.latest) {
       const timeDiff =