Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update globalUserLeaderBoard.js #704

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Update globalUserLeaderBoard.js #704

merged 1 commit into from
Apr 2, 2025

Conversation

YordiGamex
Copy link
Contributor

Add the {nickname} option, the "userLeaderBoard" role has it but the "globalUserLeaderBoard" role does not.

Description

What is sought with this change is that there are new parameters within a function

Fixes #39

Type of change

Please check options that describe your Pull Request:

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and published in downstream modules

Add the {nickname} option, the "userLeaderBoard" role has it but the "globalUserLeaderBoard" role does not.
Copy link
Member

@Faf4a Faf4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you

@Faf4a Faf4a merged commit e56c6c5 into aoijs:v6 Apr 2, 2025
@Faf4a Faf4a added this to the 6.10.0 milestone Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants