forked from apache/sedona
-
Notifications
You must be signed in to change notification settings - Fork 0
[SEDONA-659] Upgrade JTS version to 1.20.0 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#1600) 1. Replace the non-existent link https://github.com/apache/sedona/tree/master/core/src/test/resources with the valid link https://github.com/apache/sedona/tree/master/spark/common/src/test/resources 2) Some minor issues in code samples (java and python)
…e#1599) Ddd the following line in features to enable code copying feature: - content.code.copy
…ck (apache#1593) * [SEDONA-657] pre-commit add Python black hook; format Python with black Standardizes all the Python code to black format https://black.readthedocs.io/en/stable/integrations/source_version_control.html https://www.flake8rules.com/ * Add black jupyter * Remove ruff
* feat: add ST_Project * fix: snowflake tests * fix: snowflake tests 2 * address comments * chore: format python code
* feat: Add ST_Simplify * fix: snowflake tests * docs: fix formatting
* add dbscan scala * add dbscan python * add dbscan tests, pom file changes, pip changes * disable broadcast joins for all dbscan tests * disable non-sedona broadcast joins for all dbscan tests * unpersist dbscan result assuming that graphframes PR will eventually be merged. * revisions from Paweł * add documentation * styling in docs Co-authored-by: Kelly-Ann Dolor <[email protected]> * reword stats documentation Co-authored-by: Kelly-Ann Dolor <[email protected]> * clean up --------- Co-authored-by: jameswillis <[email protected]> Co-authored-by: Kelly-Ann Dolor <[email protected]>
* [DOCS] Fix spelling in Java Test file * Fix more spelling in Java and Scala files
apache#1614) * [DOCS] Upgrade pre-commit min version; add hook; pre-commit autoupdate https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0 pre-commit-hooks now requires pre-commit>=3.2.0 https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-illegal-windows-names https://pre-commit.com/#pre-commit-autoupdate * pre-commit migrate-config
…ecrets (apache#1621) https://github.com/gitleaks/gitleaks Adding another check/test to our pre-commit framework. gitleaks is a popular tool that helps with security.
Co-authored-by: jameswillis <[email protected]>
"isort is a Python utility / library to sort imports alphabetically and automatically separate into sections and by type." https://github.com/PyCQA/isort https://pycqa.github.io/isort/docs/configuration/pre-commit.html https://pycqa.github.io/isort/docs/configuration/black_compatibility.html
…le` (apache#1631) https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html#basedonstyle Standardizes the C code to one consistent format. https://github.com/pre-commit/mirrors-clang-format https://github.com/ssciwr/clang-format-wheel
* initial successful test * try add docker-compose based tests * 3.5 only * comment classic tests * try fix yaml * skip other workflows * skip other workflows * try fix if check * fix path * cd to python folder * skip sparkContext with SPARK_REMOTE * fix type check * refactor somewhat * Revert "skip other workflows" This reverts commit 7eb9b6e * back to full matrix * add license header, fix missing whitespace * Add a simple docstring to SedonaFunction * uncomment build step * need sql extensions * run pre-commit * fix lint/pre-commit * Update .github/workflows/python.yml Co-authored-by: John Bampton <[email protected]> * adjust spelling * use UnresolvedFunction instead of CallFunction * revert Pipfile to master rev --------- Co-authored-by: John Bampton <[email protected]>
Bumps [fiona](https://github.com/Toblerity/Fiona) from 1.9.6 to 1.10.0. - [Release notes](https://github.com/Toblerity/Fiona/releases) - [Changelog](https://github.com/Toblerity/Fiona/blob/main/CHANGES.txt) - [Commits](Toblerity/Fiona@1.9.6...1.10.0) --- updated-dependencies: - dependency-name: fiona dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add local outlier factor implementation. * LOF docs * precommit changes * precommit formatting changes --------- Co-authored-by: jameswillis <[email protected]>
Some changes are: - word capitalization - fixing table layouts - ordering the PMC list - minor fixups in wording
…e#1645) Minor change for improved readability. A ordered list always helps. Less chaos 👍
* Upgrade Docker CI to macos 13 * Remove MacOS build for Docker CI * Revert another change in macos
* feat: add ST_Scale and ST_ScaleGeom * fix: spark integration * docs: add docs * checking snowflake tests * fix: formatting snowflake tests * fix: snowflake tests * fix: snowflake tests 2/2 * Apply suggestions from code review Co-authored-by: John Bampton <[email protected]> --------- Co-authored-by: John Bampton <[email protected]>
* [DOCS] Add `John Bampton` as `Committer` * Update docs/community/contributor.md Co-authored-by: Jia Yu <[email protected]> * fixup --------- Co-authored-by: Jia Yu <[email protected]>
… from the python test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject
.What changes were proposed in this PR?
Upgrade JTS from 1.19.0 to 1.20.0.
Most of the changes are made to the tests due to different computation results obtained from 1.20.0. The following functions are affected from the observations of broken tests:
ST_MaximumIncribedCircle
ST_VoronoiPolygons
ST_TriangulatePolygon
ST_Buffer
ST_ConcaveHull
ST_MaximumIncribedCircle
has significant changes, while other functions only introduce slight coordinate value changes.How was this patch tested?
Passing tests.
Did this PR include necessary documentation updates?