refactor: host base images drop else and outdent #2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors error handling to simplify the code and improve readability. The changes involve removing unnecessary else blocks following error returns and restructuring the code for better clarity. Signed-off-by: Ryan Johnson <[email protected]>
spacegospod
approved these changes
Apr 29, 2025
iBrandyJackson
approved these changes
Apr 29, 2025
|
This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
dataSourceVSphereHostBaseImagesReadfunction invsphere/data_source_vsphere_host_base_images.goto improve readability and error handling. The changes primarily involve restructuring the code to eliminate the use of an inlineif-elsestatement and ensure a cleaner flow.if-elsestatement with separate variable assignment and error handling for theListBaseImagesmethod. This improves code clarity and separates concerns for better readability.