Skip to content

[JSON Reporter] value numPassedTests calculation mistake in json output #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
Emiyaaaaa opened this issue Jul 3, 2024 · 1 comment · Fixed by #6064
Closed
6 tasks done

[JSON Reporter] value numPassedTests calculation mistake in json output #6027

Emiyaaaaa opened this issue Jul 3, 2024 · 1 comment · Fixed by #6064
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) pr welcome

Comments

@Emiyaaaaa
Copy link
Contributor

Emiyaaaaa commented Jul 3, 2024

Describe the bug

I notice this code

const numPassedTests = numTotalTests - numFailedTests

https://github.com/vitest-dev/vitest/blob/main/packages/vitest/src/node/reporters/json.ts#L107

I think the skipped tests are not passed tests, this code should be

const numPassedTests = numTotalTests - numFailedTests - numSkippedTests

Reproduction

any tests with skip tests

System Info

any system

Used Package Manager

npm

Validations

@Emiyaaaaa
Copy link
Contributor Author

If possible, I want to submit a PR to resolve this.

@sheremet-va sheremet-va added pr welcome p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Jul 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants