Skip to content

Add version to custom training job request #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 17, 2024
Merged

Add version to custom training job request #501

merged 7 commits into from
May 17, 2024

Conversation

tahiyasalam
Copy link
Member

@tahiyasalam tahiyasalam commented May 13, 2024 •
edited
Loading

I will have the corresponding app and rdk PRs approved first and then I will merge this.

@tahiyasalam tahiyasalam changed the title Add version to custom training script Add version to custom training job request May 13, 2024
@github-actions github-actions bot added the safe to test committer is a member of this org label May 13, 2024
etai-shuchatowitz
etai-shuchatowitz approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@etai-shuchatowitz etai-shuchatowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOHOO!!!

@tahiyasalam tahiyasalam added ready-for-protos add this when you want protos to compile on every commit and removed ready-for-protos add this when you want protos to compile on every commit labels May 16, 2024
@tahiyasalam tahiyasalam added ready-for-protos add this when you want protos to compile on every commit protos-compiled and removed protos-compiled ready-for-protos add this when you want protos to compile on every commit labels May 16, 2024
@tahiyasalam tahiyasalam added the ready-for-protos add this when you want protos to compile on every commit label May 17, 2024
@tahiyasalam tahiyasalam removed the ready-for-protos add this when you want protos to compile on every commit label May 17, 2024
@tahiyasalam tahiyasalam merged commit 01a87a0 into main May 17, 2024
3 checks passed
@tahiyasalam tahiyasalam deleted the add-vers branch May 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etai-shuchatowitz etai-shuchatowitz etai-shuchatowitz approved these changes

Assignees
No one assigned
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tahiyasalam @etai-shuchatowitz