-
Notifications
You must be signed in to change notification settings - Fork 200
Added individual additionalConfigProperties to worker and coordinator #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Michael Cowart.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's .Values.server.coordinatorExtraConfig
, the difference is that it's a string, not a list, but I feel we should support both string and lists there instead of adding a new property.
# @raw | ||
# Example: | ||
# ```yaml | ||
# - web-ui.preview.enabled=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add these to https://github.com/trinodb/charts/blob/main/tests/trino/test-values.yaml so we know these are correct examples?
Could we please include tpl in these functions Having tpl in these is extremely helpful when we have additional environment specific values files |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
@mcowart123 the tests are failing:
|
I'm not seeing why the tests fail here and I cannot run them on my local machine due to missing tools. I do not have time/bandwidth to resolve myself so I'm going to close this. |
No description provided.