Skip to content

Added individual additionalConfigProperties to worker and coordinator #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mcowart123
Copy link

No description provided.

Copy link

cla-bot bot commented Feb 12, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Michael Cowart.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's .Values.server.coordinatorExtraConfig, the difference is that it's a string, not a list, but I feel we should support both string and lists there instead of adding a new property.

# @raw
# Example:
# ```yaml
# - web-ui.preview.enabled=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these to https://github.com/trinodb/charts/blob/main/tests/trino/test-values.yaml so we know these are correct examples?

@lozbrown
Copy link

Could we please include tpl in these functions

Having tpl in these is extremely helpful when we have additional environment specific values files

Copy link

cla-bot bot commented Feb 13, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@mcowart123 the tests are failing:

 🧪 Running test complete_values

Version increment checking disabled.
Installing charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 trino => (version: "1.37.0", path: "../../charts/trino")
------------------------------------------------------------------------------------------------------------------------

Installing chart "trino => (version: \"1.37.0\", path: \"../../charts/trino\")"...
Error: INSTALLATION FAILED: context deadline exceeded
Error: failed installing charts: failed processing charts

------------------------------------------------------------------------------------------------------------------------
 ✖︎ trino => (version: "1.37.0", path: "../../charts/trino") > failed waiting for process: exit status 1
------------------------------------------------------------------------------------------------------------------------
failed installing charts: failed processing charts

real	2m1.000s
user	0m1.299s
sys	0m0.166s
❌ Test complete_values failed

@mcowart123
Copy link
Author

I'm not seeing why the tests fail here and I cannot run them on my local machine due to missing tools. I do not have time/bandwidth to resolve myself so I'm going to close this.

@mcowart123 mcowart123 closed this Feb 13, 2025
@mcowart123 mcowart123 deleted the split-additional-config branch February 13, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants