chore!: default to 1MiB chunks and 1024 children #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Users often find it confusing that the same data results in a different UnixFS DAG and by extension a different CID. This has been discussed at length in the following forums thread.
Our current plan is to formalise these UnixFS settings into a profile that can be used across implementations to establish CID equivalency given the same input data.
What's in this PR
This PR, updates the defaults used by ipfs-car to to match the Storacha client, which is used by the w3up CLI by explicitly setting the chunk size and the dag width.
Note that these are also the defaults used by @helia/unixfs