From ee781de40c66d4d221deccea9fa6a2a53dcedf6a Mon Sep 17 00:00:00 2001 From: Qi Luo Date: Sun, 13 Nov 2022 01:30:09 +0000 Subject: [PATCH 1/3] Remove error logging on "failed in fdb_vlanmac", it is considered normal that the dependences of FDB_ENTRY are temporarily not available. --- src/sonic_ax_impl/mibs/ietf/rfc4363.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/sonic_ax_impl/mibs/ietf/rfc4363.py b/src/sonic_ax_impl/mibs/ietf/rfc4363.py index 986cd0b5d..edf4ae643 100644 --- a/src/sonic_ax_impl/mibs/ietf/rfc4363.py +++ b/src/sonic_ax_impl/mibs/ietf/rfc4363.py @@ -98,9 +98,6 @@ def update_data(self): continue vlanmac = self.fdb_vlanmac(fdb) - if not vlanmac: - mibs.logger.error("SyncD 'ASIC_DB' includes invalid FDB_ENTRY '{}': failed in fdb_vlanmac().".format(fdb_str)) - continue self.vlanmac_ifindex_map[vlanmac] = port_index self.vlanmac_ifindex_list.append(vlanmac) self.vlanmac_ifindex_list.sort() From 0221844de80b73c3c1a2fbc670f9da17744c07f6 Mon Sep 17 00:00:00 2001 From: Qi Luo Date: Sun, 13 Nov 2022 20:44:29 +0000 Subject: [PATCH 2/3] Add back the continue logic This reverts commit ee781de40c66d4d221deccea9fa6a2a53dcedf6a. --- src/sonic_ax_impl/mibs/ietf/rfc4363.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sonic_ax_impl/mibs/ietf/rfc4363.py b/src/sonic_ax_impl/mibs/ietf/rfc4363.py index edf4ae643..a95181db1 100644 --- a/src/sonic_ax_impl/mibs/ietf/rfc4363.py +++ b/src/sonic_ax_impl/mibs/ietf/rfc4363.py @@ -98,6 +98,8 @@ def update_data(self): continue vlanmac = self.fdb_vlanmac(fdb) + if not vlanmac: + continue self.vlanmac_ifindex_map[vlanmac] = port_index self.vlanmac_ifindex_list.append(vlanmac) self.vlanmac_ifindex_list.sort() From bb9b81e308453d9369f8c6896342a756ea759c73 Mon Sep 17 00:00:00 2001 From: Qi Luo Date: Mon, 14 Nov 2022 20:07:40 +0000 Subject: [PATCH 3/3] Add back debug logging --- src/sonic_ax_impl/mibs/ietf/rfc4363.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sonic_ax_impl/mibs/ietf/rfc4363.py b/src/sonic_ax_impl/mibs/ietf/rfc4363.py index a95181db1..c7c1569cd 100644 --- a/src/sonic_ax_impl/mibs/ietf/rfc4363.py +++ b/src/sonic_ax_impl/mibs/ietf/rfc4363.py @@ -99,6 +99,7 @@ def update_data(self): vlanmac = self.fdb_vlanmac(fdb) if not vlanmac: + mibs.logger.debug("SyncD 'ASIC_DB' includes invalid FDB_ENTRY '{}': failed in fdb_vlanmac().".format(fdb_str)) continue self.vlanmac_ifindex_map[vlanmac] = port_index self.vlanmac_ifindex_list.append(vlanmac)