From 458a46f7d262e0ad8b95bf46ceac514114b565ed Mon Sep 17 00:00:00 2001 From: Stephen Sun Date: Wed, 25 Aug 2021 10:18:26 +0000 Subject: [PATCH 1/4] Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor Signed-off-by: Stephen Sun --- syncd/Syncd.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/syncd/Syncd.cpp b/syncd/Syncd.cpp index b4468e33c..6ac6e15dc 100644 --- a/syncd/Syncd.cpp +++ b/syncd/Syncd.cpp @@ -706,9 +706,14 @@ sai_status_t Syncd::processGetStatsEvent( std::vector entry; - if (status != SAI_STATUS_SUCCESS) + if (SAI_STATUS_IS_ATTR_NOT_SUPPORTED(status) || SAI_STATUS_IS_ATTR_NOT_IMPLEMENTED(status) + || status == SAI_STATUS_NOT_SUPPORTED || status == SAI_STATUS_NOT_IMPLEMENTED) + { + SWSS_LOG_NOTICE("Getting stats on %s is not supported on the platform", key.c_str()); + } + else if (status != SAI_STATUS_SUCCESS) { - SWSS_LOG_ERROR("Failed to get stats"); + SWSS_LOG_ERROR("Error occurred when getting stats on %s", key.c_str()); } else { From 55534abe2426a50b6b210ff6dec052388022a876 Mon Sep 17 00:00:00 2001 From: Stephen Sun Date: Thu, 26 Aug 2021 10:05:20 +0000 Subject: [PATCH 2/4] Fix review comments Signed-off-by: Stephen Sun --- syncd/Syncd.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/syncd/Syncd.cpp b/syncd/Syncd.cpp index 6ac6e15dc..a9994b071 100644 --- a/syncd/Syncd.cpp +++ b/syncd/Syncd.cpp @@ -713,7 +713,7 @@ sai_status_t Syncd::processGetStatsEvent( } else if (status != SAI_STATUS_SUCCESS) { - SWSS_LOG_ERROR("Error occurred when getting stats on %s", key.c_str()); + SWSS_LOG_NOTICE("Getting stats error"); } else { From d607fe8ea7a73830e6ecd66947079e5ecbe07274 Mon Sep 17 00:00:00 2001 From: Stephen Sun Date: Thu, 26 Aug 2021 10:09:51 +0000 Subject: [PATCH 3/4] Fix review comments Signed-off-by: Stephen Sun --- syncd/Syncd.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/syncd/Syncd.cpp b/syncd/Syncd.cpp index a9994b071..1320a316d 100644 --- a/syncd/Syncd.cpp +++ b/syncd/Syncd.cpp @@ -706,12 +706,7 @@ sai_status_t Syncd::processGetStatsEvent( std::vector entry; - if (SAI_STATUS_IS_ATTR_NOT_SUPPORTED(status) || SAI_STATUS_IS_ATTR_NOT_IMPLEMENTED(status) - || status == SAI_STATUS_NOT_SUPPORTED || status == SAI_STATUS_NOT_IMPLEMENTED) - { - SWSS_LOG_NOTICE("Getting stats on %s is not supported on the platform", key.c_str()); - } - else if (status != SAI_STATUS_SUCCESS) + if (status != SAI_STATUS_SUCCESS) { SWSS_LOG_NOTICE("Getting stats error"); } From 567d580733ec8224c4d3b6c9c5eb41dbbd469d69 Mon Sep 17 00:00:00 2001 From: Stephen Sun Date: Thu, 26 Aug 2021 10:28:19 +0000 Subject: [PATCH 4/4] Add error code Signed-off-by: Stephen Sun --- syncd/Syncd.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/syncd/Syncd.cpp b/syncd/Syncd.cpp index 1320a316d..d57d0e556 100644 --- a/syncd/Syncd.cpp +++ b/syncd/Syncd.cpp @@ -708,7 +708,7 @@ sai_status_t Syncd::processGetStatsEvent( if (status != SAI_STATUS_SUCCESS) { - SWSS_LOG_NOTICE("Getting stats error"); + SWSS_LOG_NOTICE("Getting stats error: %s", sai_serialize_status(status).c_str()); } else {