-
Notifications
You must be signed in to change notification settings - Fork 398
Add logger to Weights & Biases #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
79ead54
feat(wandb): add logger to Weights & Biases
borisdayma 10fdefa
docs(changes.md): add reference to WandbLogger
borisdayma d17c35a
feat(wandb): add run instance to callback
borisdayma 3864919
Merge branch 'master' of https://github.com/skorch-dev/skorch into fe…
borisdayma 5d8f780
test(wandb): added tests
borisdayma 5907832
feat(requirements-dev.txt): add wandb
borisdayma 5ef1bde
docs(wandb): add documentation
borisdayma e54fe59
feat(wandb): update doc
borisdayma 2991565
refactor(wandb): address comments
borisdayma 9198011
feat(wandb): remove ref to _watch_called
borisdayma 3ca5741
feat(wandb): set minimum version
borisdayma 5785ac0
docs(wandb): log anonymous + upload model
borisdayma 7d3a775
feat(wandb): simplify logged_vals
borisdayma 878b619
feat(wandb): implement comments
borisdayma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,4 @@ pytest-cov | |
sphinx | ||
sphinx_rtd_theme | ||
tensorboard>=1.14.0 | ||
wandb>=0.8.30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,5 +33,6 @@ | |
'TrainEndCheckpoint', | ||
'TensorBoard', | ||
'Unfreezer', | ||
'WandbLogger', | ||
'WarmRestartLR', | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already provide a checkpoint callback, I think this functionality is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to log the trained model to W&B.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. How does that work? In this code, I don't see any interaction with W&B:
Is this some code working in the background or is it simply the fact that the model parameters are stored in the
wandb_run_dir
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files stored in wandb_run.dir are automatically saved.
You can see in my example run on the "files" tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave a comment that states that the files in
wandb_run.dir
is automatically saved inon_epoch_end
.