Support chain-supplied validator voluntary exits #300

diegomrsantos · 2025-04-30T15:51:12Z

Issue Addressed

Proposed Changes

This PR adds support for chain-supplied voluntary exits by introducing dedicated tracking and processing components for validator exit requests. Key changes include the creation of a voluntary exit tracker and processor, integration of signature collection within the validator store, and the subsequent wiring of these components into the client and event sync flows.

Additional Info

In the next PR, I'll use the tracker for duty validation.

# Conflicts: # anchor/eth/src/sync.rs

Copilot

Pull Request Overview

This PR introduces support for chain-supplied voluntary exits by adding new functionality to collect signatures, process exit requests, and update event processing accordingly.

Added asynchronous function to collect voluntary exit signatures in the validator store.
Implemented a new voluntary exit processor and integrated it into the event processor and client startup flow.
Updated dependency exports and adjusted operator validation and error handling in related modules.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
anchor/validator_store/src/lib.rs	Added the collect_voluntary_exit_signatures function to handle exits.
anchor/signature_collector/src/lib.rs	Changed the ssv_types import to be public.
anchor/eth/src/voluntary_exit_processor.rs	Introduced a new module to process voluntary exit requests asynchronously.
anchor/eth/src/util.rs	Added debug logging in operator validation.
anchor/eth/src/sync.rs	Integrated exit processor into syncer construction.
anchor/eth/src/lib.rs	Re-exported the new voluntary exit processor module.
anchor/eth/src/event_processor.rs	Updated exit handling in validator exit events and related helper functions.
anchor/eth/Cargo.toml	Added dependency on anchor_validator_store.
anchor/common/ssv_types/src/share.rs	Derived Eq and PartialEq for Share for equality comparisons.
anchor/client/src/lib.rs	Created and passed exit channel; started the voluntary exit processor.

Comments suppressed due to low confidence (1)

anchor/eth/src/event_processor.rs:644

The error type in get_validator_index is nested (Result<Option, Result<(), ExecutionError>>) which is unusual and may lead to confusion. Simplify the return type to Result<Option, ExecutionError> and adjust the error return accordingly.

fn get_validator_index(&self, validator_pubkey: &PublicKeyBytes) -> Result<Option<ValidatorIndex>, Result<(), ExecutionError>> {

Copilot

Pull Request Overview

This PR introduces support for chain-supplied validator voluntary exits by adding new functionality to collect and process voluntary exit signatures, as well as integrating these exits into the event processing and client startup flow.

Introduces a new async method in the validator store to collect voluntary exit signatures.
Adds a new voluntary exit processor component and integrates it into the event processor and client.
Adjusts module exports and dependencies to support voluntary exit processing.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
anchor/validator_store/src/lib.rs	Adds a new async function to collect voluntary exit signatures.
anchor/signature_collector/src/lib.rs	Makes ssv_types publicly accessible.
anchor/eth/src/voluntary_exit_processor.rs	Implements processing and submission of voluntary exit requests.
anchor/eth/src/util.rs	Adds debug logging for operator validation.
anchor/eth/src/sync.rs	Injects the exit_tx into the event syncer.
anchor/eth/src/lib.rs	Exposes the voluntary exit processor module.
anchor/eth/src/event_processor.rs	Integrates exit processing into validator exit events.
anchor/eth/Cargo.toml	Updates dependencies to include the validator store module.
anchor/common/ssv_types/src/share.rs	Derives additional traits for Share.
anchor/client/src/lib.rs	Sets up the voluntary exit processor channel and startup.

Comments suppressed due to low confidence (1)

anchor/eth/src/event_processor.rs:639

[nitpick] If the removal of the metrics counter for validator exits was intended, please confirm that exit processing metrics are tracked elsewhere; otherwise, consider retaining or relocating this metric update for consistency.

// metrics::inc_counter_vec(&metrics::EXECUTION_EVENTS_PROCESSED, &["validator_exited"]);

anchor/eth/src/voluntary_exit_processor.rs

# Conflicts: # anchor/eth/src/event_processor.rs # anchor/signature_collector/src/lib.rs

dknopik

Nice, looks good overall! Some first comments below, will test it out tomorrow.

anchor/eth/src/event_processor.rs

anchor/validator_store/src/lib.rs

anchor/eth/src/voluntary_exit_processor.rs

Copilot

Pull Request Overview

This PR adds support for chain-supplied voluntary exits by introducing new modules to track and process exit requests from validators. Key changes include:

Implementation of a voluntary exit tracker that schedules and prunes exit duties.
Addition of an asynchronous voluntary exit processor integrated into the event processing and client startup flows.
Updates to dependencies and adjustments in the validator store, event processor, and client to support voluntary exit functionality.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
anchor/voluntary_exit/src/voluntary_exit_tracker.rs	Implements tracking and scheduling of voluntary exit duties.
anchor/voluntary_exit/src/voluntary_exit_processor.rs	Adds asynchronous exit request processing and scheduling logic.
anchor/voluntary_exit/src/lib.rs	Exports the new voluntary exit modules.
anchor/voluntary_exit/Cargo.toml	Declares the voluntary_exit crate and its dependencies.
anchor/validator_store/src/lib.rs	Introduces collection of voluntary exit signatures.
anchor/signature_collector/src/lib.rs	Re-exports ssv_types for external usage.
anchor/eth/src/util.rs	Adds logging during operator validation.
anchor/eth/src/sync.rs	Passes exit_tx to the event syncer for exit processing.
anchor/eth/src/event_processor.rs	Integrates voluntary exit request handling into event processing.
anchor/eth/Cargo.toml	Adds voluntary_exit dependency to the eth crate.
anchor/client/src/lib.rs	Creates the voluntary exit processing channel and initiates processing.
anchor/client/Cargo.toml	Adds voluntary_exit dependency to the client crate.
Cargo.toml	Includes voluntary_exit in workspace members.
anchor/common/ssv_types/src/share.rs	Updates Share struct with equality derivations.

anchor/eth/src/event_processor.rs

dknopik · 2025-05-14T10:26:49Z

anchor/client/src/lib.rs

@@ -346,11 +349,17 @@ impl Client {
        let index_sync_tx =
            start_validator_index_syncer(beacon_nodes.clone(), database.clone(), executor.clone());

+        // We create the channel here so that we can pass the receiver to the syncer. But we need to
+        // delay starting the voluntary exit processor until we have created the validator store.
+        let (exit_tx, exit_rx) = unbounded_channel();


You know my liberal policy about unbounded_channel that have a natural boundary due to on-chain limitations ;D

Still, if you want you can estimate how many exits can be burst in a single block, add some safety margin on top and apply that as limit.

anchor/eth/src/event_processor.rs

anchor/validator_store/src/lib.rs

anchor/voluntary_exit/Cargo.toml

anchor/voluntary_exit/src/voluntary_exit_processor.rs

Zacholme7

Small nits, really good job here!

anchor/eth/src/event_processor.rs

# Conflicts: # anchor/eth/src/sync.rs

Copilot

Pull Request Overview

This PR adds support for chain-supplied voluntary exits by introducing dedicated tracking and processing components for validator exit requests. Key changes include the creation of a voluntary exit tracker and processor, integration of signature collection within the validator store, and the subsequent wiring of these components into the client and event sync flows.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
anchor/voluntary_exit/src/voluntary_exit_tracker.rs	New tracker for scheduling and managing exit duties.
anchor/voluntary_exit/src/voluntary_exit_processor.rs	New asynchronous processor for handling exit requests.
anchor/voluntary_exit/src/lib.rs	Module exports for voluntary exit functionality.
anchor/voluntary_exit/Cargo.toml	Cargo configuration for the new voluntary exit package.
anchor/validator_store/src/lib.rs	Added function for collecting partial voluntary exit signatures.
anchor/signature_collector/src/lib.rs	Exposed ssv_types with pub use to support shared usage.
anchor/eth/src/util.rs	Added provider factory functions with timeout and fallback.
anchor/eth/src/sync.rs	Updated event syncer to include exit_tx and utilize the new HTTP provider helper.
anchor/client/src/lib.rs	Integrated voluntary exit processor into the client startup flow.
anchor/client/Cargo.toml	Included voluntary exit dependency.
Cargo.toml	Updated workspace members to include voluntary_exit module.

anchor/voluntary_exit/src/voluntary_exit_processor.rs

Co-authored-by: Copilot <[email protected]>

anchor/eth/src/sync.rs

dknopik

LGTM, thank you! Will defer to @jking-aus for final approval due to architectural significance.

Copilot

Pull Request Overview

Adds support for chain-supplied voluntary exits by introducing a voluntary exit tracker and processor, integrating exit signature collection into the validator store, and wiring these components through the event sync and client flows.

New modules voluntary_exit_tracker and voluntary_exit_processor to schedule and execute exit duties.
Extended the validator store with collect_voluntary_exit_partial_signatures.
Refactored HTTP provider setup into a shared util and integrated exit handling into SsvEventSyncer and Client.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`anchor/voluntary_exit/src/voluntary_exit_tracker.rs`	Tracks and manages scheduled exit duties per slot
`anchor/voluntary_exit/src/voluntary_exit_processor.rs`	Receives exit requests, schedules, and processes them
`anchor/validator_store/src/lib.rs`	Added `collect_voluntary_exit_partial_signatures` method
`anchor/signature_collector/src/lib.rs`	Changed `use ssv_types` to `pub use ssv_types`
`anchor/eth/src/util.rs`	Extracted HTTP provider with timeout + fallback logic
`anchor/eth/src/sync.rs`	Wired in exit channel, removed duplicated provider code
`anchor/eth/src/event_processor.rs`	Made `process_logs` async, dispatches `ValidatorExited` via exit queue
`anchor/client/src/lib.rs`	Started exit processor from the client
`anchor/common/ssv_types/src/share.rs`	Added `Eq`/`PartialEq` to `Share`

Comments suppressed due to low confidence (3)

anchor/voluntary_exit/src/voluntary_exit_processor.rs:83

Using unwrap_or_default on slot_of may silently schedule exits at slot 0 if conversion fails; consider handling the error explicitly or logging it.

let exit_slot = slot_clock.slot_of(Duration::from_secs(block_timestamp)).unwrap_or_default();

anchor/voluntary_exit/src/voluntary_exit_tracker.rs:37

The new tracker methods (e.g., add_duty_for_slot, get_ready_exits, prune) are untested; adding unit tests would help ensure correct behavior.

pub fn add_duty_for_slot(

anchor/eth/src/event_processor.rs:557

[nitpick] The metrics counter for processed ValidatorExited events is commented out; consider restoring or removing it explicitly to keep instrumentation consistent.

// metrics::inc_counter_vec(

Copilot · 2025-05-15T13:24:55Z

anchor/voluntary_exit/src/voluntary_exit_tracker.rs

+    /// Get all exits that should be processed at or before the given slot
+    /// Returns the exits without removing them from the tracker


[nitpick] Consider adding doc comments to explain the behavior of get_ready_exits, especially that it does not remove entries and that removal is handled elsewhere.

Suggested change

/// Get all exits that should be processed at or before the given slot

/// Returns the exits without removing them from the tracker

/// Get all exits that should be processed at or before the given slot.

///

/// This method retrieves a list of `ExitDuty` objects representing the exits

/// scheduled for processing at or before the specified `current_slot`. It does

/// not modify or remove any entries from the tracker. Removal of processed exits

/// is handled separately by the `remove_processed_exit` method.

///

/// # Parameters

/// - `current_slot`: The slot up to which exits should be retrieved.

///

/// # Returns

/// A `Vec<ExitDuty>` containing the exits ready for processing.

Copilot · 2025-05-15T13:24:55Z

anchor/voluntary_exit/src/voluntary_exit_tracker.rs

+    }
+
+    /// Remove a specific exit that has been successfully processed
+    pub fn remove_processed_exit(&self, exit_duty: &ExitDuty) {


The all_duties_by_slot map is never decremented when an exit is removed, which may lead to stale counts; consider cleaning it up in remove_processed_exit or during pruning.

That's a very good point. They don't decrement the counter in the go implementation. Any idea why? @dknopik @nkryuchkov

@diegomrsantos We remove the entire slot data after one epoch: https://github.com/ssvlabs/ssv/blob/v2.3.1/operator/duties/voluntary_exit.go#L117. Or did you mean anything else?

Copilot · 2025-05-15T13:24:56Z

anchor/signature_collector/src/lib.rs

@@ -9,7 +9,7 @@ use dashmap::{DashMap, Entry};
 use message_sender::MessageSender;
 use processor::{Error, Error::Queue, Senders, work::DropOnFinish};
 use slot_clock::SlotClock;
-use ssv_types::{
+pub use ssv_types::{


[nitpick] Re-exporting the entire ssv_types public API may expose internals unintentionally; consider re-exporting only the needed types.

anchor/common/ssv_types/src/share.rs

Co-authored-by: Copilot <[email protected]>

Initial implementation

3352b0c

diegomrsantos changed the base branch from stable to unstable April 30, 2025 15:51

add signature collection

847ace9

diegomrsantos force-pushed the voluntary-exit branch from e0df2f2 to 847ace9 Compare May 5, 2025 18:36

Merge branch 'unstable' into voluntary-exit

d6ac318

# Conflicts: # anchor/eth/src/sync.rs

diegomrsantos requested a review from Copilot May 5, 2025 18:48

Copilot AI reviewed May 5, 2025

View reviewed changes

diegomrsantos added 2 commits May 5, 2025 20:56

fix get_validator_index

fddb299

check the owner for all validators; process exit only for our validators

9b264ba

diegomrsantos requested a review from Copilot May 5, 2025 20:41

diegomrsantos self-assigned this May 5, 2025

diegomrsantos marked this pull request as ready for review May 5, 2025 20:41

Copilot AI reviewed May 5, 2025

View reviewed changes

anchor/eth/src/voluntary_exit_processor.rs Outdated Show resolved Hide resolved

fix is_our_validator

ce1964d

diegomrsantos requested review from dknopik and jking-aus May 5, 2025 22:26

diegomrsantos and others added 3 commits May 6, 2025 13:17

Merge branch 'unstable' into voluntary-exit

3109ab7

add docs to verify_validator_owner

89c2cea

Merge branch 'unstable' into voluntary-exit

0f74f32

# Conflicts: # anchor/eth/src/event_processor.rs # anchor/signature_collector/src/lib.rs

diegomrsantos force-pushed the voluntary-exit branch from 5b503d1 to 0f74f32 Compare May 6, 2025 12:50

add doc for get_validator_index

b459206

dknopik reviewed May 6, 2025

View reviewed changes

diegomrsantos and others added 4 commits May 6, 2025 17:41

parse block_timestamp as secs

92f81c7

Merge branch 'unstable' into voluntary-exit

7120a81

fix formatting

6929260

process exit at the right slot

6eec9ff

diegomrsantos requested a review from Copilot May 8, 2025 16:19

Merge branch 'unstable' into voluntary-exit

b7fe568

Copilot AI reviewed May 8, 2025

View reviewed changes

get block ts from exec client if not available

d0da421

dknopik reviewed May 14, 2025

View reviewed changes

diegomrsantos added 2 commits May 14, 2025 13:19

simplify match

d0fb2c0

use workspace edition and add authors

36b78b0

diegomrsantos commented May 14, 2025

View reviewed changes

anchor/voluntary_exit/src/voluntary_exit_processor.rs Outdated Show resolved Hide resolved

Zacholme7 reviewed May 14, 2025

View reviewed changes

anchor/eth/src/event_processor.rs Show resolved Hide resolved

anchor/eth/src/event_processor.rs Outdated Show resolved Hide resolved

anchor/eth/src/event_processor.rs Show resolved Hide resolved

diegomrsantos commented May 14, 2025

View reviewed changes

anchor/eth/src/event_processor.rs Show resolved Hide resolved

diegomrsantos added 8 commits May 14, 2025 15:37

make code more idiomatic

c0d5ae6

renaming to collect_voluntary_exit_partial_signatures

e38a411

Merge branch 'unstable' into voluntary-exit

6c6a289

# Conflicts: # anchor/eth/src/sync.rs

remove retry

ef660fb

use duration_to_next_slot instead of calculate_sleep_duration

6d792c4

lint

61e7737

remove last_processed_slot

d458461

remove unused code

57d7a64

diegomrsantos requested a review from Copilot May 14, 2025 16:17

Copilot AI reviewed May 14, 2025

View reviewed changes

anchor/voluntary_exit/src/voluntary_exit_processor.rs Outdated Show resolved Hide resolved

Update anchor/voluntary_exit/src/voluntary_exit_processor.rs

34fa7f1

Co-authored-by: Copilot <[email protected]>

dknopik reviewed May 15, 2025

View reviewed changes

anchor/eth/src/sync.rs Outdated Show resolved Hide resolved

diegomrsantos and others added 4 commits May 15, 2025 11:54

use voluntary_exit.get_domain

e53362c

return error when cluster is liquidated

fab92a4

Merge branch 'unstable' into voluntary-exit

1736e8f

simplify is_our_operator

bd8c8a3

diegomrsantos requested a review from Copilot May 15, 2025 13:18

dknopik reviewed May 15, 2025

View reviewed changes

Copilot AI reviewed May 15, 2025

View reviewed changes

diegomrsantos and others added 3 commits May 15, 2025 16:51

Update anchor/common/ssv_types/src/share.rs

7980067

Co-authored-by: Copilot <[email protected]>

update ShareMultiIndexMap docs

f4d7877

Merge branch 'unstable' into voluntary-exit

cebe4e8

jking-aus approved these changes May 16, 2025

View reviewed changes

jking-aus merged commit 288e3d1 into sigp:unstable May 16, 2025
12 checks passed

		/// Get all exits that should be processed at or before the given slot
		/// Returns the exits without removing them from the tracker

-    /// Get all exits that should be processed at or before the given slot
-    /// Returns the exits without removing them from the tracker
+    /// Get all exits that should be processed at or before the given slot.
+    ///
+    /// This method retrieves a list of `ExitDuty` objects representing the exits
+    /// scheduled for processing at or before the specified `current_slot`. It does
+    /// not modify or remove any entries from the tracker. Removal of processed exits
+    /// is handled separately by the `remove_processed_exit` method.
+    ///
+    /// # Parameters
+    /// - `current_slot`: The slot up to which exits should be retrieved.
+    ///
+    /// # Returns
+    /// A `Vec<ExitDuty>` containing the exits ready for processing.

Support chain-supplied validator voluntary exits #300

Support chain-supplied validator voluntary exits #300

Uh oh!

Conversation

diegomrsantos commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Proposed Changes

Additional Info

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dknopik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dknopik May 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zacholme7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

dknopik left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 15, 2025

Choose a reason for hiding this comment

Uh oh!

diegomrsantos May 15, 2025

Choose a reason for hiding this comment

Uh oh!

nkryuchkov May 20, 2025

diegomrsantos commented Apr 30, 2025 •

edited

Loading