chore: enable begin rule from thelper #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR enables the begin rule from thelper by reverting the previous disabled configuration in the linter and refactors test files to use a common helper function for handling not-implemented errors.
- Introduced a new common function (SkipIfNotImplementedErr) in the common package.
- Replaced duplicate skip helper functions across various test files with the common implementation.
- Updated the .golangci.yml configuration to remove the disabled begin rules for thelper.
Reviewed Changes
| File | Description |
|---|---|
| internal/common/common_testing.go | Adds the new common helper function for skipping not-implemented tests. |
| internal/common/common.go | Adds ErrNotImplementedError and removes the old duplicate definition. |
| .golangci.yml | Removes the disabled thelper settings to enable the begin rule. |
| Various test files in cpu, mem, net, host, process, etc. | Replace local skipIfNotImplementedErr with common.SkipIfNotImplementedErr. |
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
|
That’s my first review by @copilot , interesting to see how accurate it can be . |
mmorel-35
force-pushed
the
thelper/begin
branch
from
a17e57a to
ebdef9a
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
thelper/begin
branch
from
ebdef9a to
a5e4967
Compare
shirou
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables begin rule from thelper, it also turns SkipIfNotImplementedErr into a common function