[net][host][aix] Fix build and Makefile #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lomanic
changed the title
|
I'm late to the party, but this actually introduced a bug. The redundant |
|
@Dylan-M ah, so you mean the case should be like this? If so, I will open a another PR. |
That is correct. Sorry for the delayed reply. It has been very busy at work, or I would have just submitted my own quick PR for this. Instead I'm deep into the bowels of AIX working on adding Process metrics support for this library ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with
CGO_ENABLED=0 GOOS=aix GOARCH=ppc64 go test ./... | grep -v "exec format error" | grep "build failed"Amends #1797
Fixes #1806