Skip to content

fix(HLS): Do not skip DateRanges based on ID #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

tykus160
Copy link
Member

According to HLS spec, there might be few date ranges with the same ID, which complement each other (i.e. SCTE35-IN / SCTE35-OUT).

If date ranges are true duplicates (i.e. due to live update) it will be filter out anyway by RegionTimeline logic.

@tykus160 tykus160 added this to the v4.15 milestone May 22, 2025
@tykus160 tykus160 requested review from avelad and TAhub May 22, 2025 09:45
@tykus160 tykus160 added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels May 22, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit c6b53b3 into shaka-project:main May 22, 2025
48 of 51 checks passed
avelad pushed a commit that referenced this pull request May 29, 2025
According to HLS spec, there might be few date ranges with the same ID,
which complement each other (i.e. SCTE35-IN / SCTE35-OUT).

If date ranges are true duplicates (i.e. due to live update) it will be
filter out anyway by `RegionTimeline` logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants