-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Add HDR detection in Tizen and WebOS #8680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Incremental code coverage: 32.08% |
* @override | ||
*/ | ||
getHdrLevel(preferHLG) { | ||
if (this.supportHdr_ == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this means that we won't get a fully accurate value until the getConfigs
call has completed, right?
Unfortunately, both of the contexts that call this method are synchronous, and call shaka.device.DeviceFactory.getDevice()
immediately before calling this method, so we can't just make this async...
Right now, shaka.device.DeviceFactory
uses a lazy-load pattern. If there are values that won't load synchronously when the device object is first created, it's possible that we might have to move to making the device object immediately when calling registerDefaultDeviceFactory
, if only for webos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some more verbose comments to easify debugging in case of issues. I added my suggestions, but feel free to adjust them.
Co-authored-by: Wojciech Tyczyński <[email protected]>
Co-authored-by: Wojciech Tyczyński <[email protected]>
Close #8441