Skip to content

feat: Add HDR detection in Tizen and WebOS #8680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 3, 2025

Close #8441

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent platform: WebOS Issues affecting WebOS platform: Tizen Issues affecting Tizen labels Jun 3, 2025
@avelad avelad added this to the v4.15 milestone Jun 3, 2025
@avelad avelad requested review from joeyparrish, TAhub and tykus160 June 3, 2025 14:09
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 3, 2025

Incremental code coverage: 32.08%

TAhub
TAhub previously requested changes Jun 4, 2025
* @override
*/
getHdrLevel(preferHLG) {
if (this.supportHdr_ == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this means that we won't get a fully accurate value until the getConfigs call has completed, right?

Unfortunately, both of the contexts that call this method are synchronous, and call shaka.device.DeviceFactory.getDevice() immediately before calling this method, so we can't just make this async...

Right now, shaka.device.DeviceFactory uses a lazy-load pattern. If there are values that won't load synchronously when the device object is first created, it's possible that we might have to move to making the device object immediately when calling registerDefaultDeviceFactory, if only for webos.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@avelad avelad requested a review from TAhub June 4, 2025 09:22
@avelad avelad modified the milestones: v4.15, v4.16 Jun 4, 2025
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more verbose comments to easify debugging in case of issues. I added my suggestions, but feel free to adjust them.

avelad and others added 2 commits June 4, 2025 12:10
Co-authored-by: Wojciech Tyczyński <[email protected]>
Co-authored-by: Wojciech Tyczyński <[email protected]>
@avelad avelad requested a review from tykus160 June 4, 2025 10:10
@avelad avelad dismissed TAhub’s stale review June 4, 2025 10:34

Approved by Wojciech

@avelad avelad merged commit ff1ef7c into shaka-project:main Jun 4, 2025
30 of 33 checks passed
@avelad avelad deleted the hdr-tizen-webos branch June 4, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Tizen Issues affecting Tizen platform: WebOS Issues affecting WebOS priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HDR playback on LG possible?
4 participants