Skip to content

fix: Only create shaka-text-container when necessary #8581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented May 9, 2025

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels May 9, 2025
@avelad avelad added this to the v4.15 milestone May 9, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 78.12%

@avelad avelad merged commit 3618d4f into shaka-project:main May 9, 2025
49 of 54 checks passed
@avelad avelad deleted the ui-text-displayer branch May 9, 2025 20:05
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 8, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants