feat: Expose Vast ad ID #8477
Merged
feat: Expose Vast ad ID #8477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykus160
added
type: enhancement
tykus160
previously requested changes
Apr 17, 2025
added 2 commits
April 17, 2025 12:12
There was a problem hiding this comment.
@tykus160 thank you, I removed the method from the IMA and IMA Dai interfaces.
Keeping the functions to comply with shaka.extern.IAd but just returning empty string
avelad
approved these changes
Apr 21, 2025
|
Incremental code coverage: 83.33% |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Tailor ads have a property called "vastAdId". This PR exposes it in the same way as the rest of the ads' properties, so it's available for use e.g. in analytics reporting.
Closes #8474