fix: Only expand robustness on each stream once #8458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
avelad
changed the title
avelad
added
type: bug
avelad
approved these changes
Apr 15, 2025
tykus160
approved these changes
Apr 15, 2025
avelad
pushed a commit
that referenced
this pull request
Apr 21, 2025
Without this change, `expandRobustness` ended up running 480 times for the stream `Angel One (multicodec, multilingual, Widevine)` with `SW_SECURE_CRYPTO,SW_SECURE_CRYPTO,SW_SECURE_CRYPTO` set up as the multiple robustness. With it, it only runs 44 times, which is expected because there are 22 unique streams, and it expands `videoRobustness` and `audioRobustness` on each. Fixes #8408
avelad
pushed a commit
that referenced
this pull request
Apr 21, 2025
Without this change, `expandRobustness` ended up running 480 times for the stream `Angel One (multicodec, multilingual, Widevine)` with `SW_SECURE_CRYPTO,SW_SECURE_CRYPTO,SW_SECURE_CRYPTO` set up as the multiple robustness. With it, it only runs 44 times, which is expected because there are 22 unique streams, and it expands `videoRobustness` and `audioRobustness` on each. Fixes #8408
tykus160
added a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
May 20, 2025
Cherry picks shaka-project#8458 Without this change, `expandRobustness` ended up running 480 times for the stream `Angel One (multicodec, multilingual, Widevine)` with `SW_SECURE_CRYPTO,SW_SECURE_CRYPTO,SW_SECURE_CRYPTO` set up as the multiple robustness. With it, it only runs 44 times, which is expected because there are 22 unique streams, and it expands `videoRobustness` and `audioRobustness` on each. Co-authored-by: Gary Katsevman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change,
expandRobustnessended up running 480 times for the streamAngel One (multicodec, multilingual, Widevine)withSW_SECURE_CRYPTO,SW_SECURE_CRYPTO,SW_SECURE_CRYPTOset up as the multiple robustness. With it, it only runs 44 times, which is expected because there are 22 unique streams, and it expandsvideoRobustnessandaudioRobustnesson each.Fixes #8408