Skip to content

feat(Offline): Make timeout for opening IndexedDB configurable #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

feat(Offline): Make timeout for opening IndexedDB configurable #8366

merged 3 commits into from
Apr 1, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 31, 2025

Close #8355

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: offline The issue involves the offline storage system of Shaka Player labels Mar 31, 2025
@avelad avelad added this to the v4.15 milestone Mar 31, 2025
@avelad avelad mentioned this pull request Mar 31, 2025
Closed
@avelad
Copy link
Member Author

avelad commented Mar 31, 2025

FYI @loicraux

@loicraux
Copy link
Contributor

Thanks @avelad , I did not think of this straightforward solution 🤣 ....

What happens if I set shaka.offline.indexeddb.StorageMechanismOpenTimeout to zero ? I'd like to be able to have no timeout at all...

@avelad
Copy link
Member Author

avelad commented Mar 31, 2025

Thanks @avelad , I did not think of this straightforward solution 🤣 ....

What happens if I set shaka.offline.indexeddb.StorageMechanismOpenTimeout to zero ? I'd like to be able to have no timeout at all...

That's a case outside the scope of this PR, so we can do it in another PR, maybe tomorrow? Would you be willing to do it yourself since you proposed the idea?

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@loicraux
Copy link
Contributor

loicraux commented Apr 1, 2025

That's a case outside the scope of this PR, so we can do it in another PR, maybe tomorrow? Would you be willing to do it yourself since you proposed the idea?

yes, I am OK to work on another PR to add this capability.

@avelad avelad merged commit 5752a21 into shaka-project:main Apr 1, 2025
12 of 16 checks passed
@avelad avelad deleted the indexeddb-timeout branch April 1, 2025 09:48
@shaka-bot shaka-bot mentioned this pull request Apr 1, 2025
Merged
@loicraux loicraux mentioned this pull request Apr 1, 2025
Merged
avelad added a commit that referenced this pull request Apr 1, 2025
@loicraux @avelad @tykus160
feat(Offline): Allow no timeout when opening IndexedDB database (#8372)
8cd2c01 
This is the followup to the previous PR #8366 , to allow to disable the
timeout, as per @avelad
[suggestion](#8366 (comment))
to add this in another PR...

---------

Co-authored-by: Loïc Raux <[email protected]>
Co-authored-by: Álvaro Velad Galván <[email protected]>
Co-authored-by: Wojciech Tyczyński <[email protected]>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 31, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.15
Development

Successfully merging this pull request may close these issues.

Make timeout for opening IndexedDB configurable
4 participants
@avelad @loicraux @shaka-bot @tykus160