Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Attach env vars from kube config when renewing token #209

Merged
merged 4 commits into from
May 18, 2020

Conversation

cscetbon
Copy link
Contributor

@cscetbon cscetbon commented May 11, 2020

Solves #207

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cscetbon ! I have a minor comment. Also, can you bump the package version so this will be automatically released once merged?

@cscetbon
Copy link
Contributor Author

Thanks for the PR @cscetbon ! I have a minor comment. Also, can you bump the package version so this will be automatically released once merged?

@andresmgot done, see my last commits. It seems there are issues in your travis scripts

@andresmgot
Copy link
Contributor

Thanks for the changes! A bit difficult to spot, but your changes have some lint errors:

/home/travis/build/serverless/serverless-kubeless/lib/helpers.js
  132:48  error  Strings must use singlequote    quotes
  132:50  error  Missing semicolon               semi
  137:35  error  A space is required after '{'   object-curly-spacing
  137:48  error  A space is required before '}'  object-curly-spacing

Once that's fixed we can land this

@cscetbon
Copy link
Contributor Author

@andresmgot I fixed those errors. Not sure what Travis complains about.

@andresmgot
Copy link
Contributor

Seems just a transient error with xip.io. This is fine now, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants