Support rosdep check without skipping rosdep install

[matlabbe]

I have an issue when testing my package on new ROS distros if some dependencies are not yet released, action-ros-ci action doesn't fail when rosdep says:
ERROR: the following packages/stacks could not have their rosdep keys resolved to system dependencies:

In the code, rosdep install uses -r option, meaning "Continue installing despite errors.":

action-ros-ci/src/action-ros-ci.ts

Lines 201 to 204 in 8dce037

	# suppress errors from unresolved install keys to preserve backwards compatibility
	# due to difficulty reading names of some non-catkin dependencies in the ros2 core
	# see https://index.ros.org/doc/ros2/Installation/Foxy/Linux-Development-Setup/#install-dependencies-using-rosdep
	rosdep install -r --from-paths $package_paths --ignore-src --skip-keys "rti-connext-dds-5.3.1 rti-connext-dds-6.0.1 rti-connext-dds-7.3.0 ${filterNonEmptyJoin(

My current workaround is to remove skip-rosdep-install requirement to use rosdep-check option.

Related to this PR: #830

[christophebedard]

Merci for the PR!

The -r option for rosdep install has been used since the very beginning. Since rosdep install installs one dependency at a time, I thought that the -r option made it keep installing dependencies instead of stopping right away if a dependency can't be found or if there are errors when installing it. And I thought that it would still fail if there were any errors (see also #957). However, it does seem like -r prevents it from exiting with a non-zero code.

I think -r is used to try to avoid flakiness when installing dependencies. At one point, GitHub CI used some kind of Azure-hosted Ubuntu package mirror, which regularly failed (ros-tooling/setup-ros#25). However, I don't think that's the case anymore, and it hides actual issues, as you said. We should consider eventually removing -r, but this PR makes sense on its own, so I think we can proceed.

[christophebedard]

Released as 0.4.4/v0.4.

[matlabbe]

Thank you for the fast review, I saw the -r was there since the beginning, so I preferred to play safe with the option instead. :)

Cordialement