Skip to content

Commit ce2df62

Browse files
authored
Support rosdep check without skipping rosdep install (#988)
Signed-off-by: matlabbe <[email protected]>
1 parent 8dce037 commit ce2df62

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ This action builds and tests a [ROS](http://wiki.ros.org/) or [ROS 2](https://do
2121
1. [Generate and process code coverage data](#Generate-and-process-code-coverage-data)
2222
1. [Store `colcon` logs as build artifacts](#Store-colcon-logs-as-build-artifacts)
2323
1. [Use with private repos](#Use-with-private-repos)
24-
1. [Skip `rosdep install`](#Skip-rosdep-install)
24+
1. [Skip `rosdep install` and run `rosdep check`](#Skip-rosdep-install-and-run-rosdep-check)
2525
1. [Interdependent pull requests or merge requests](#Interdependent-pull-requests-or-merge-requests)
2626
1. [Developing](#Developing)
2727
1. [License](#License)
@@ -411,7 +411,7 @@ For example, if this secret is called `REPO_TOKEN`:
411411
Note that this currently only works for tokens for the GitHub server this action runs on.
412412
For example, it will not work with a token for a private repo on github.com when the action is running on an enterprise GitHub server.
413413

414-
### Skip `rosdep install`
414+
### Skip `rosdep install` and run `rosdep check`
415415

416416
Include an option to bypass `rosdep install` for workflow that uses specific docker image that is expected to already have all dependencies.
417417
To check for missing dependencies within the workflow's image, user can run with `rosdep-check: true` flag.

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ inputs:
100100
rosdep-check:
101101
default: ""
102102
description: |
103-
Check dependencies of packages using 'rosdep check'. Must be used with skip-rosdep-install.
103+
Check dependencies of packages using 'rosdep check'.
104104
Set to 'true'.
105105
required: false
106106
rosdep-skip-keys:

dist/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31199,7 +31199,7 @@ done`;
3119931199
if (!isWindows && !skipRosdepInstall) {
3120031200
yield installRosdeps(buildPackageSelection, rosdepSkipKeysSelection, rosWorkspaceDir, options, targetRos1Distro, targetRos2Distro);
3120131201
}
31202-
if (skipRosdepInstall && rosdepCheck) {
31202+
if (rosdepCheck) {
3120331203
yield checkRosdeps(buildPackageSelection, rosdepSkipKeysSelection, rosWorkspaceDir, options, targetRos1Distro, targetRos2Distro);
3120431204
}
3120531205
// Print list of Python packages and their version

src/action-ros-ci.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ done`;
683683
);
684684
}
685685

686-
if (skipRosdepInstall && rosdepCheck) {
686+
if (rosdepCheck) {
687687
await checkRosdeps(
688688
buildPackageSelection,
689689
rosdepSkipKeysSelection,

0 commit comments

Comments
 (0)