From 3c194f7c1e753104b4b1f43c35c01d011df6d246 Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Tue, 7 Jan 2025 15:16:17 +0100 Subject: [PATCH] fix(datasource/docker): handle empty `newValue` in `getDigest` --- lib/modules/datasource/docker/index.spec.ts | 11 +++++++---- lib/modules/datasource/docker/index.ts | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/modules/datasource/docker/index.spec.ts b/lib/modules/datasource/docker/index.spec.ts index 68096768f24baf..768dacc88d61b4 100644 --- a/lib/modules/datasource/docker/index.spec.ts +++ b/lib/modules/datasource/docker/index.spec.ts @@ -98,10 +98,13 @@ describe('modules/datasource/docker/index', () => { .reply(200, { token: 'some-token' }); hostRules.find.mockReturnValue({}); - const res = await getDigest({ - datasource: 'docker', - packageName: 'some-dep', - }); + const res = await getDigest( + { + datasource: 'docker', + packageName: 'some-dep', + }, + '', + ); expect(res).toBe('some-digest'); }); diff --git a/lib/modules/datasource/docker/index.ts b/lib/modules/datasource/docker/index.ts index b6082a6455ef31..3e4339d0fa2b25 100644 --- a/lib/modules/datasource/docker/index.ts +++ b/lib/modules/datasource/docker/index.ts @@ -831,7 +831,7 @@ export class DockerDatasource extends Datasource { // TODO: types (#22198) `getDigest(${registryHost}, ${dockerRepository}, ${newValue})`, ); - const newTag = newValue ?? 'latest'; + const newTag = is.nonEmptyString(newValue) ? newValue : 'latest'; let digest: string | null = null; try { let architecture: string | null | undefined = null;