From 73cc9997795287ef1a528e8d61cac2bc6645b4dd Mon Sep 17 00:00:00 2001 From: Markus Podar Date: Sat, 8 May 2021 22:10:35 +0200 Subject: [PATCH] Remove provides from ServiceProvider I'm pretty sure this one is only used for deferred providers [1]. However we do more then just registered services, thus with the current Laravel architecture we can't make it deferred [1] https://laravel.com/docs/8.x/providers#deferred-providers --- phpstan-baseline.neon | 5 ----- src/GraphQLServiceProvider.php | 13 ------------- 2 files changed, 18 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 796fc9fb..2e54889b 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -80,11 +80,6 @@ parameters: count: 1 path: src/GraphQLController.php - - - message: "#^Method Rebing\\\\GraphQL\\\\GraphQLServiceProvider\\:\\:provides\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/GraphQLServiceProvider.php - - message: "#^Access to an undefined property GraphQL\\\\Type\\\\Definition\\\\InputObjectField\\|stdClass\\:\\:\\$alias\\.$#" count: 1 diff --git a/src/GraphQLServiceProvider.php b/src/GraphQLServiceProvider.php index d47d30ad..b392e8ed 100644 --- a/src/GraphQLServiceProvider.php +++ b/src/GraphQLServiceProvider.php @@ -155,17 +155,4 @@ public function registerConsole(): void $this->commands(TypeMakeCommand::class); $this->commands(UnionMakeCommand::class); } - - /** - * Get the services provided by the provider. - * - * @return array - */ - public function provides() - { - return [ - GraphQL::class, - 'graphql', - ]; - } }