diff --git a/lib/package.js b/lib/package.js index 4984c53..7583097 100644 --- a/lib/package.js +++ b/lib/package.js @@ -18,7 +18,10 @@ Package.prototype.updateRequired = function() { var version = this.versionSpecified; var isGitRepo = require('./git-repo'); var semver = require('semver'); - if (isGitRepo(version)) { + + if (version === '*') { + return false; + } else if (isGitRepo(version)) { var parts = version.split('#'); if (parts.length === 2) { version = semver.valid(parts[1]); diff --git a/package.json b/package.json index 63d1621..3737d8c 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,8 @@ "scripts": { "start": "ember server", "build": "ember build", - "test": "node tests/runner" + "test": "node tests/runner", + "test:debug": "node debug tests/runner" }, "repository": { "type": "git", diff --git a/tests/unit/dependency-checker-bower-test.js b/tests/unit/dependency-checker-bower-test.js index bfb9075..76f090b 100644 --- a/tests/unit/dependency-checker-bower-test.js +++ b/tests/unit/dependency-checker-bower-test.js @@ -92,5 +92,10 @@ describe('EmberCLIDependencyChecker', function() { var project = createProject({ 'ember': '~/projects/emberjs' }); assertNoBowerError(project); }); + + it('does NOT error with a * dependency', function() { + var project = createProject({ 'ember': '*' }); + assertNoBowerError(project); + }); }); }); diff --git a/tests/unit/dependency-checker-npm-test.js b/tests/unit/dependency-checker-npm-test.js index d12ccc9..03f1123 100644 --- a/tests/unit/dependency-checker-npm-test.js +++ b/tests/unit/dependency-checker-npm-test.js @@ -82,5 +82,10 @@ describe('EmberCLIDependencyChecker', function() { var project = createProject({ 'ember-cli': '~/projects/ember-cli' }); assertNoNpmError(project); }); + + it('does NOT error with a * dependency', function() { + var project = createProject({ 'ember-cli': '*' }); + assertNoNpmError(project); + }); }); });