Skip to content

[DONT MERGE] Debug branch for the Qwen3 + full model compile #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anijain2305
Copy link

@anijain2305 anijain2305 commented Jun 16, 2025

Take this PR. This just turns of compile and full model compilation, and then sets up the config values that you finish the program quickly. Use the instructions at the beginning of this file - https://github.com/pytorch/torchtune/blob/main/recipes/configs/qwen3/8B_full_single_device.yaml

torch.compile takes 198 seconds to fine-tune (with warmup). Eager takes only 48 seconds. If we do regional compile (compile only the transformer layers), it takes 35 seconds. So, something really bad is going on.

Copy link

pytorch-bot bot commented Jun 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2831

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs

As of commit 39b9193 with merge base 2344509 (image):

NEW FAILURES - The following jobs have failed:

  • GPU tests / gpu_test (3.11, stable) (gh)
    tests/recipes/test_full_finetune_distributed.py::TestFullFinetuneDistributedRecipe::test_training_state_on_resume_from_distributed_checkpoint_multi_rank[llama3/8B_full-llama3_hf_138m-1-4-False]
  • Lint / lint (3.10) (gh)
    torchtune/training/_compile.py:13:1: F401 'torchtune.modules.TransformerSelfAttentionLayer' imported but unused

CANCELLED JOBS - The following jobs were cancelled. Please retry:

  • GPU tests / gpu_test (3.10, stable) (gh)
    tests/recipes/test_full_finetune_distributed.py::TestFullFinetuneDistributedRecipe::test_training_state_on_resume_from_distributed_checkpoint_multi_rank[llama3/8B_full-llama3_hf_138m-1-4-False]
  • GPU tests / gpu_test (3.9, stable) (gh)
    tests/recipes/test_full_finetune_distributed.py::TestFullFinetuneDistributedRecipe::test_training_state_on_resume_from_distributed_checkpoint_multi_rank[llama3/8B_full-llama3_hf_138m-1-4-False]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants