-
Notifications
You must be signed in to change notification settings - Fork 79
JitterBuffer: Improve performance for SampleBuilder use #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 78.52% 78.55% +0.02%
==========================================
Files 81 82 +1
Lines 5136 5520 +384
==========================================
+ Hits 4033 4336 +303
- Misses 928 1000 +72
- Partials 175 184 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'll try it later! |
@thatsnotright I tested this branch locally in my usecase and confirmed that SampleBuilder's performance is good! (mostly same CPU/memory usage as the latest release) |
@at-wat Thank you for taking the time to test, I appreciate your time! I'll clean up the code a little and make some test coverage improvements and then work with @Sean-Der on next steps! |
ea085bb
to
ab615fe
Compare
521c4f0
to
339f38e
Compare
339f38e
to
6d35fb4
Compare
3ff714b
to
6982678
Compare
7639fd0
to
72641d8
Compare
72641d8
to
e99f243
Compare
e7aab86
to
8e6a4ed
Compare
9e75f82
to
77fa007
Compare
831d68f
to
6572218
Compare
Rework the jitterbuffer for SampleBuilder use Allow Skipping packets
6572218
to
2de1b4e
Compare
Description
This PR Should hopefully improve the performance for use by SampleBuilder and in the general case.
@at-wat If you have time would you be able to test this PR and the corresponding branch I created in the webrtc repository? pion/webrtc#2959
Thank you!