Skip to content

JitterBuffer: Improve performance for SampleBuilder use #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thatsnotright
Copy link
Contributor

Description

This PR Should hopefully improve the performance for use by SampleBuilder and in the general case.

@at-wat If you have time would you be able to test this PR and the corresponding branch I created in the webrtc repository? pion/webrtc#2959

Thank you!

@thatsnotright thatsnotright requested a review from at-wat November 26, 2024 23:51
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 83.50000% with 66 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (149728f) to head (2de1b4e).

Files with missing lines Patch % Lines
pkg/jitterbuffer/rbtree.go 84.26% 45 Missing and 11 partials ⚠️
pkg/jitterbuffer/jitter_buffer.go 61.53% 5 Missing ⚠️
pkg/jitterbuffer/receiver_interceptor.go 80.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   78.52%   78.55%   +0.02%     
==========================================
  Files          81       82       +1     
  Lines        5136     5520     +384     
==========================================
+ Hits         4033     4336     +303     
- Misses        928     1000      +72     
- Partials      175      184       +9     
Flag Coverage Δ
go 78.44% <83.50%> (-0.09%) ⬇️
wasm 76.35% <83.50%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@at-wat
Copy link
Member

at-wat commented Nov 27, 2024

I'll try it later!

@at-wat
Copy link
Member

at-wat commented Dec 10, 2024

@thatsnotright I tested this branch locally in my usecase and confirmed that SampleBuilder's performance is good! (mostly same CPU/memory usage as the latest release)

@thatsnotright
Copy link
Contributor Author

@thatsnotright I tested this branch locally in my usecase and confirmed that SampleBuilder's performance is good! (mostly same CPU/memory usage as the latest release)

@at-wat Thank you for taking the time to test, I appreciate your time! I'll clean up the code a little and make some test coverage improvements and then work with @Sean-Der on next steps!

@thatsnotright thatsnotright force-pushed the rob/jb_perf branch 2 times, most recently from ea085bb to ab615fe Compare February 26, 2025 00:11
@thatsnotright thatsnotright force-pushed the rob/jb_perf branch 4 times, most recently from 521c4f0 to 339f38e Compare April 2, 2025 00:36
@thatsnotright thatsnotright force-pushed the rob/jb_perf branch 3 times, most recently from 3ff714b to 6982678 Compare April 29, 2025 00:46
@thatsnotright thatsnotright force-pushed the rob/jb_perf branch 3 times, most recently from 7639fd0 to 72641d8 Compare May 7, 2025 00:21
@thatsnotright thatsnotright force-pushed the rob/jb_perf branch 5 times, most recently from e7aab86 to 8e6a4ed Compare May 29, 2025 00:46
@thatsnotright thatsnotright force-pushed the rob/jb_perf branch 6 times, most recently from 9e75f82 to 77fa007 Compare June 11, 2025 00:12
@thatsnotright thatsnotright force-pushed the rob/jb_perf branch 2 times, most recently from 831d68f to 6572218 Compare June 11, 2025 00:30
Rework the jitterbuffer for SampleBuilder use
Allow Skipping packets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants