Skip to content

✨ feat/images: add account filter when fetching images by name #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

jfbus
Copy link
Contributor

@jfbus jfbus commented Feb 11, 2025

Using image names is dangerous: multiple images having the same name may be published by multiple accounts.

This PR adds the ability to specify the account owner.

Additional changes:

  • remove default image id, the image needs to be set
  • test image only at bastion/machine creation to ensure that reconciliation does not fail if image was removed
  • machine reconciliation: remove 1 API call

@jfbus jfbus force-pushed the feat/image_account_id branch from 58a597b to a45e6f4 Compare February 11, 2025 15:56
@jfbus jfbus changed the title ✨ feat/images: add account_id filter when fetching images by name ✨ feat/images: add account filter when fetching images by name Feb 17, 2025
@jfbus jfbus marked this pull request as ready for review February 17, 2025 09:55
@jfbus jfbus force-pushed the feat/image_account_id branch 8 times, most recently from 4f69482 to 369cb14 Compare February 21, 2025 14:27
@jfbus jfbus added this to the v0.4.0 milestone Feb 24, 2025
@jfbus jfbus force-pushed the feat/image_account_id branch 3 times, most recently from 5fab0c5 to 8b9a832 Compare March 3, 2025 11:55
@jfbus jfbus force-pushed the feat/image_account_id branch from 8b9a832 to b5716c5 Compare March 3, 2025 12:41
@jfbus jfbus merged commit e024d2e into main Mar 3, 2025
7 checks passed
@jfbus jfbus deleted the feat/image_account_id branch March 3, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants