Skip to content

fix(cluster): security group rules reconcile #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Aug 5, 2024

What type of PR is this?

/kind bug Fixes a SecurityGroup rules reconcile with DNS IpPrococol and PortRange limit enforced to -1

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #346

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@sebglon sebglon force-pushed the fix/securitygrouprules-reconcile branch from 88c789f to 664db7c Compare August 5, 2024 13:11
@sebglon sebglon force-pushed the fix/securitygrouprules-reconcile branch from 664db7c to 0d4e31a Compare August 6, 2024 10:20
Copy link
Contributor

@outscale-hmi outscale-hmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@outscale-hmi outscale-hmi merged commit 0403afb into outscale:main Aug 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fail to reconcile securitygroup
2 participants