Skip to content

Feat/net/controlplane Manage FailureDomain on multipld az #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 5, 2023

Conversation

sebglon
Copy link
Contributor

@sebglon sebglon commented Nov 21, 2023

What type of PR is this?

/kind feature New functionality with test.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #287, #284

Special notes for your reviewer:
related documentation: kubernetes-sigs/cluster-api#2131
DEPENDENCIES:
#276

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@sebglon sebglon force-pushed the feat/net/controlplane-multi-az branch from 22353f1 to b0d8a82 Compare November 21, 2023 13:37
@gvdhart
Copy link
Contributor

gvdhart commented Nov 23, 2023

DEPENDENCIES:
#276

@sebglon sebglon changed the title Feat/net/controlplane multi az Feat/net/controlplane Manage FailureDomain on multipld az Nov 24, 2023
@sebglon sebglon force-pushed the feat/net/controlplane-multi-az branch 2 times, most recently from 80c1427 to fd14303 Compare November 27, 2023 13:04
@ghost
Copy link

ghost commented Dec 4, 2023

@sebglon @gvdhart
Is that PR ready ?
Please rebase now from main ?
And resolve conflict ?

@sebglon sebglon force-pushed the feat/net/controlplane-multi-az branch from 2adf37e to b0148aa Compare December 4, 2023 09:41
@sebglon
Copy link
Contributor Author

sebglon commented Dec 4, 2023

@outscale-vbr PR is ready

@sebglon sebglon force-pushed the feat/net/controlplane-multi-az branch from fbdffb3 to 847446e Compare December 4, 2023 10:05
@ghost
Copy link

ghost commented Dec 4, 2023

@sebglon @gvdhart
Can you also rebase again from main ?

@ghost
Copy link

ghost commented Dec 4, 2023

Error: controllers/oscmachine_vm_controller_unit_test.go:3624:3: expListMachine redeclared
Error: 	controllers/oscmachine_vm_controller_unit_test.go:3621:3: other declaration of expListMachine
Error: controllers/oscmachine_vm_controller_unit_test.go:3693:18: duplicate field name expListMachine in struct literal

@sebglon sebglon force-pushed the feat/net/controlplane-multi-az branch 2 times, most recently from 89ca119 to 6a62572 Compare December 4, 2023 11:10
@sebglon sebglon force-pushed the feat/net/controlplane-multi-az branch from 6a62572 to 4e7d49d Compare December 4, 2023 11:11
@sebglon
Copy link
Contributor Author

sebglon commented Dec 4, 2023

@outscale-vbr fixed

@ghost
Copy link

ghost commented Dec 4, 2023

Ok

@ghost ghost self-requested a review December 5, 2023 12:19
@ghost ghost merged commit f90fb94 into outscale:main Dec 5, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Manage ControlPlane déployment on Multi AZ
2 participants