Skip to content

Update boilerplate format #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from Mar 10, 2023
Merged

Update boilerplate format #232

1 commit merged into from Mar 10, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2023 •
edited by ghost
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
homogenize boilerplate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@ghost ghost requested a review from outscale-hmi March 8, 2023 13:11
outscale-hmi
outscale-hmi reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@outscale-hmi outscale-hmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should rebase, you pushed the same changes in another PR

outscale-hmi
outscale-hmi approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@outscale-hmi outscale-hmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ghost ghost merged commit 1914144 into outscale:main Mar 10, 2023
@ghost ghost added the kind/cleanup Cleanup label Jul 20, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/cleanup Cleanup
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@outscale-hmi @vincentBaer