Add tag on cluster #228
Merged
Add tag on cluster #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
assigned
ghost
marked this pull request as ready for review
|
@outscale-mdr @outscale-hmi Are you ok with this PR ? |
outscale-hmi
reviewed
Mar 9, 2023
cloud/tag/tag.go
Outdated
| // AddTag add a tag to a resource | ||
| //func AddTag(tagKey string, tagValue string, resourceIds []string, api *osc.APIClient, auth context.Context) (error, *http.Response) { | ||
| // func AddTag(tagKey string, tagValue string, resourceIds []string, api *osc.APIClient, auth context.Context) (error, *http.Response) { |
There was a problem hiding this comment.
you can remove comment because parameters are not the same as the function
hack/boilerplate/boilerplate.py
Outdated
| @@ -149,7 +148,7 @@ def file_extension(filename): | |||
|
|
|||
| skipped_dirs = ['Godeps', 'third_party', '_gopath', '_output', '.git', 'cluster/env.sh', | |||
| "vendor", "test/e2e/generated/bindata.go", "hack/boilerplate/test", | |||
| "pkg/kubectl/generated/bindata.go", "tilt_modules", "cloud/services/net/mock_net", "cloud/services/security/mock_security", "cloud/services/service/mock_service", "cloud/services/storage/mock_storage", "cloud/services/compute/mock_compute", "api/v1beta1/zz_generated.deepcopy.go"] | |||
| "pkg/kubectl/generated/bindata.go", "tilt_modules", "cloud/services/net/mock_net", "cloud/services/security/mock_security", "cloud/services/service/mock_service", "cloud/services/storage/mock_storage", "cloud/services/compute/mock_compute", "cloud/tag/mock_tag", "api/v1beta1/zz_generated.deepcopy.go"] | |||
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use tag name not to have duplicate cluster if the api is down during the first initialization.
Closes #183
Which issue(s) this PR fixes:
Fixes #183
Special notes for your reviewer:
TODOs: