Rework Logs content and Format #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#221 will be merge first to handle cve. |
ghost
requested a review
from 
outscale-mdr
requested changes
Feb 9, 2023
|
@outscale-mdr Are you ok with this PR ? |
| @@ -1422,6 +1429,7 @@ spec: | |||
| - --health-probe-bind-address=:8081 | |||
| - --metrics-bind-address=127.0.0.1:8080 | |||
| - --leader-elect | |||
| - --zap-log-level=10 | |||
There was a problem hiding this comment.
Still positive integer ?
| @@ -32,3 +32,4 @@ spec: | |||
| - "--health-probe-bind-address=:8081" | |||
| - "--metrics-bind-address=127.0.0.1:8080" | |||
| - "--leader-elect" | |||
| - "--zap-log-level=10" | |||
outscale-mdr
approved these changes
Feb 20, 2023
ghost
added
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Rework logs and improve logs format
Close #207
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #207
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: