update default architecture and remove Nat subnet #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-hmi
force-pushed
the
newArchitecture2
branch
4 times, most recently
from
6d7ed2e to
d1d202d
Compare
ghost
reviewed
Dec 14, 2022
| @@ -170,11 +170,11 @@ func TestCheckNetFormatParameters(t *testing.T) { | |||
| Network: infrastructurev1beta1.OscNetwork{ | |||
| Net: infrastructurev1beta1.OscNet{ | |||
| Name: "test-net", | |||
| IpRange: "10.0.0.256/16", | |||
| IpRange: "10.0.0.256/8", | |||
There was a problem hiding this comment.
Please change to use the new default values.
There was a problem hiding this comment.
It's for a use case : "check Bad Ip Range IP Net"
| @@ -39,16 +39,14 @@ spec: | |||
| net: | |||
| name: cluster-api-net | |||
| clusterName: cluster-api | |||
| ipRange: "10.0.0.0/24" | |||
| ipRange: "10.0.0.0/16" | |||
There was a problem hiding this comment.
Please change to use the new default values.
There was a problem hiding this comment.
The default net Ip range is 10.0.0.0/16
| @@ -127,28 +118,28 @@ spec: | |||
| flow: Inbound | |||
| ipProtocol: tcp | |||
| # IpRange to authorize access to kubernetes endpoints (kube-apiserver), you must keep it and change it with a CIDR that best suits with your environment. | |||
| ipRange: "10.0.0.128/26" | |||
| ipRange: "10.0.0.128/24" | |||
There was a problem hiding this comment.
Please change to use the new default values.
| @@ -1135,7 +1119,7 @@ var _ = Describe("Outscale Cluster Reconciler", func() { | |||
| PrivateIps: []infrastructurev1beta1.OscPrivateIpElement{ | |||
| { | |||
| Name: "cluster-api-privateip-kcp", | |||
| PrivateIp: "10.0.0.39", | |||
| PrivateIp: "10.0.4.10", | |||
outscale-hmi
force-pushed
the
newArchitecture2
branch
from
d1d202d to
703a318
Compare
ghost
self-requested a review
outscale-hmi
force-pushed
the
newArchitecture2
branch
from
703a318 to
8bde209
Compare
|
Good jobs. |
ghost
approved these changes
Dec 16, 2022
| @@ -1135,7 +1119,7 @@ var _ = Describe("Outscale Cluster Reconciler", func() { | |||
| PrivateIps: []infrastructurev1beta1.OscPrivateIpElement{ | |||
| { | |||
| Name: "cluster-api-privateip-kcp", | |||
| PrivateIp: "10.0.0.39", | |||
| PrivateIp: "10.0.4.10", | |||
| @@ -39,16 +39,14 @@ spec: | |||
| net: | |||
| name: cluster-api-net | |||
| clusterName: cluster-api | |||
| ipRange: "10.0.0.0/24" | |||
| ipRange: "10.0.0.0/16" | |||
ghost
force-pushed
the
newArchitecture2
branch
from
c791d3e to
46f96d5
Compare
Signed-off-by: outscale_hmi <[email protected]>
ghost
force-pushed
the
newArchitecture2
branch
from
46f96d5 to
7c69860
Compare
ghost
added
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: outscale_hmi [email protected]