Autogenerate docs #159
Merged
Autogenerate docs #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
outscale-hmi
and removed request for
outscale-hmi
ghost
assigned
|
Close #164 |
outscale-mdr
requested changes
Oct 31, 2022
Comment on lines
+13
to
+15
| repository: 'outscale-vbr/image-builder' | ||
| path: "add-outscale-image" | ||
| ref: add-outscale-image |
There was a problem hiding this comment.
Any reason to go back to our fork ?
There was a problem hiding this comment.
@outscale-mdr
https://github.com/outscale-vbr/image-builder/pull/2/files
Yes because packer use now outscale instead of osc.
I have to add a new PR to image builder.
There was a problem hiding this comment.
When those PR (and also the one with global permission ) will be accept, review, merged, we will switch back to the official repo.
|
@outscale-mdr @outscale-hmi Are you ok with the latest changes ? |
outscale-mdr
approved these changes
Nov 8, 2022
Comment on lines
+28
to
+31
| GH_ORG_NAME ?= outscale-dev | ||
| GH_REPO_NAME ?= cluster-api-provider-outscale | ||
| GIT_USERNAME ?= Outscale Bot | ||
| GIT_USEREMAIL ?= [email protected] |
There was a problem hiding this comment.
It is on both secret to override it
|
@outscale-hmi Are you ok with latest changes ? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Auto generate docs version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #160
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: